FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle indented comments in git config files (issue #17) by tmzullinger · Pull Request #18 · gitpython-developers/GitPython · GitHub

Repository navigation

Handle indented comments in git config files (issue #17) - #18

Closed
tmzullinger wants to merge 1 commit into
gitpython-developers:masterfrom
tmzullinger:master
Closed

tmzullinger wants to merge 1 commit into
gitpython-developers:masterfrom
tmzullinger:master

Conversation

Copy link
Copy Markdown
Contributor

It's perfectly valid for a git config file to contain comments inside
sections, e.g.:

[core]
    # This is a shared repository
    sharedRepository = true

The git tools all parse this fine while GitPython was choking on it.

It's perfectly valid for a git config file to contain comments inside
sections, e.g.:

[core]
	# This is a shared repository
	sharedRepository = true

The git tools all parse this fine while GitPython was choking on it.

Byron commented May 24, 2011

Copy link
Copy Markdown
Member

Could you modify and existing fixture (like. git_config in test/fixtures) to contain comments, maybe including some variations you make up that you think should be fine as well.

Once that works, I will be glad to merge.
Thanks,
Sebastian

Byron commented Jun 7, 2011

Copy link
Copy Markdown
Member

I have implemented the contents of this pull request and pushed the changes to the new 0.3 branch. This is to indicate that GitPython 0.3 reached the end of its life and is in maintenance mode. A proper release of 0.3 will follow.

Master now moved on to the latest stable development, which will be 0.4 one day. As master was reset, you will have to reset your local master as well.

Thanks for your participation,
Sebastian

Byron closed this Jun 7, 2011
govtech42 pushed a commit to mirror81/GitPython that referenced this pull request Jul 25, 2026
minor spell fixes + empty line unification + comparison for python 2.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL