FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix `git push` hanging when stdout/stderr is big by msabramo · Pull Request #184 · gitpython-developers/GitPython · GitHub

  1. gitpython-developers
  2. GitPython

Repository navigation

Fix git push hanging when stdout/stderr is big #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 1 commit into from
Aug 17, 2014
Conversation 4 Commits 1 Checks 0 Files changed
Merged

Fix git push hanging when stdout/stderr is big #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
6 changes: 3 additions & 3 deletions git/db/cmd/base.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,11 @@ def get_push_info(repo, remotename_or_url, proc, progress):
# we hope stdout can hold all the data, it should ...
# read the lines manually as it will use carriage returns between the messages
# to override the previous one. This is why we read the bytes manually
digest_process_messages(proc.stderr, progress)
stdout, stderr = proc.communicate()
digest_process_messages(StringIO(stderr), progress)

output = IterableList('name')
for line in proc.stdout.readlines():
for line in stdout.splitlines():
try:
output.append(CmdPushInfo._from_line(repo, remotename_or_url, line))
except ValueError:
Expand All @@ -139,7 +140,6 @@ def get_push_info(repo, remotename_or_url, proc, progress):
# END exception handling
# END for each line

finalize_process(proc)
return output


Expand Down
Back | FazBrowse Home | New Git URL