Fixed an error updating shallow submodules - #1899
Merged
Byron merged 1 commit intoApr 8, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fixed the error of updating shallow submodules
Copy link
Copy Markdown
Member
|
Do these numbers in =5 = [up to date] zm/160_uwp -> origin/zm/160_uwp (=5 =) look like an issue with parallelism on the server side, or do they have meaning? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I don't think so. I've found this number only in one branch. Other branches didn't have this number. |
Sorry, something went wrong.
Byron
approved these changes
Apr 8, 2024
Byron
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you.
The new regex would unconditionally consume up to three characters, just as long as there is one more to capture, followed by a space.
This should be safe and handle this particular case.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we try to execute
submodule_update(recursive=True, init=True)
in Repo class with shallow submodules, command
git fetch --progress -v origin
sometimes print log such as
=5 = [up to date] zm/160_uwp -> origin/zm/160_uwp
but it doesn't satisfy filter:
r"^ (.) ([[\w .$@]+]|[\w.$@]+) +(.+) -> ([^ ]+)( (.)?$)?"
and throw exception.
I've updated it so that it works correctly.