FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump Vampire/setup-wsl from 3.0.0 to 3.1.0 by dependabot[bot] · Pull Request #1917 · gitpython-developers/GitPython · GitHub

/ GitPython Public

Bump Vampire/setup-wsl from 3.0.0 to 3.1.0 - #1917

Merged
Byron merged 2 commits into
mainfrom
dependabot/github_actions/Vampire/setup-wsl-3.1.0
May 28, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Bump Vampire/setup-wsl from 3.0.0 to 3.1.0#1917
Byron merged 2 commits into
mainfrom
dependabot/github_actions/Vampire/setup-wsl-3.1.0

Conversation

dependabot Bot commented on behalf of github May 27, 2024

Copy link
Copy Markdown
Contributor

Bumps Vampire/setup-wsl from 3.0.0 to 3.1.0.

Release notes

Sourced from Vampire/setup-wsl's releases.

v3.1.0

Highlights

  • Make Alpine work again (#50)
  • Add support for Ubuntu 24.04 (#57)
  • Add a warning about /etc/wsl.conf being overwritten

Details

  • Update GitHub Actions workflows DSL to 1.14.0 [1b98bdaffc3d56b5e97a29ea8b3b2a96c0498c03]
  • Use eq for outcome [319454a321c55c67fef12c67cd54ec54af7d4997]
  • Use newest versions of actions [130e9cba97252d50ab178c5782859460aede274f]
  • Update github-workflows-kt to 2.0.0 [a7c820261d48105e7bd3e6ae3cc393eb1ed58843]
  • Add debug logging if the product ID could not be resolved to a download URL [a5e8694107a925a6701ee61f2470e1a226407cf1]
  • Work around KT-42101 when preprocessing workflows [a6c8b145c3c422dd3974a1b112a7652becdaaff3]
  • Make procuctId to URL translation work again (#50) [e5717e2bbf1f10981bbe1bd2f35544b4b6905ec9]
  • Refactor test workflow script [00dc521491958bb3a5dd2e5d51357f913e198972]
  • Log contents of /etc/wsl.conf if it exists unexpectedly [d81efaebccf8b931f6a6ee383e8efd8786ff084f]
  • Increase version to 3.1.0 [9be6f77b85829f8361d5e1faa99c9e56ac57b3a5]
  • Add support for Ubuntu 24.04 (#57) [a2f462bb0930b2a1bd97a2c0d236754f810fe39d]
  • Make test_distribution_specific_wsl_bash_scripts names unique [d29d1570b60eded291f19b1585224c2a55df5ba8]
  • Add a warning about /etc/wsl.conf being overwritten [b7c49fbd112783fce649d00c69328972a98e9da5]
Commits
  • 45f5a8c [Gradle Release Plugin] - pre tag commit: 'v3.1.0'.
  • b7c49fb Add a warning about /etc/wsl.conf being overwritten
  • d29d157 Make test_distribution_specific_wsl_bash_scripts names unique
  • a2f462b Add support for Ubuntu 24.04 (#57)
  • 9be6f77 Increase version to 3.1.0
  • d81efae Log contents of /etc/wsl.conf if it exists unexpectedly
  • 00dc521 Refactor test workflow script
  • e5717e2 Make procuctId to URL translation work again (#50)
  • a6c8b14 Work around KT-42101 when preprocessing workflows
  • a5e8694 Add debug logging if the product ID could not be resolved to a download URL
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bump Vampire/setup-wsl from 3.0.0 to 3.1.0
d3b181d 
Bumps [Vampire/setup-wsl](https://github.com/vampire/setup-wsl) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/vampire/setup-wsl/releases)
- [Commits](Vampire/setup-wsl@v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: Vampire/setup-wsl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels May 27, 2024
EliahKagan mentioned this pull request May 27, 2024
Closed

EliahKagan commented May 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

There appear to be two separate kinds of failures here.

The failure with Python 3.7 on Ubuntu appears to be a result of a corrupted download, which should resolve if re-run.

In contrast, it seems the failures on Windows always occur with that step, as written, to install Debian, at least on windows-latest, as shown in this much-simplified testing repository. I've opened Vampire/setup-wsl#58 to report that.

Although we should probably wait for feedback on Vampire/setup-wsl#58 (and possibly a fix) before attempting further steps toward bringing in the changes from this PR, I suggest rerunning all pythonpackage.yml tests here, to check that my prediction is correct.

It may not be strictly necessary to do so, since I have made a branch in my fork from this branch here, whose CI does behave that way. But rerunning them all here should give slightly greater confidence and, perhaps more importantly, should make it clearer, when we (or others, perhaps to fix the issue) look at this later, which test jobs fail consistently.

Vampire commented May 27, 2024

Copy link
Copy Markdown

The setup-wsl problem should be fixed in 3.1.1, sorry

Byron reviewed May 27, 2024
View reviewed changes
Comment thread .github/workflows/pythonpackage.yml Outdated

EliahKagan commented May 28, 2024

Copy link
Copy Markdown
Member

@Vampire That's great, thanks!!

EliahKagan approved these changes May 28, 2024
View reviewed changes

EliahKagan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. It is working since 3.1.1 was released and this was further bumped to it, so I think this can be merged.

Although Dependabot could be made to redo the version update in which case the PR title its commit message would have 3.1.1-specific links, I think that's not necessary and the manual bump, as already done here, is sufficient. The commit history will make clear that the action was upgraded to 3.1.1. (If you do want to do that, I think just having Dependabot redo the version update scan with the "Check for updates" button in "Recent update jobs" would be sufficient; I believe that would cause Dependabot to close this PR and open another one. I emphasize that I am not requesting this.)

Some subsequent changes may make sense, such as changing Debian to Alpine. As discussed in #1745, this was waiting on Vampire/setup-wsl#50, which is now fixed. However, since the value of upgrading is not contingent on that, I recommend merging this PR first. Afterwards, I can experiment with and, if it seems helpful, open a PR to change Debian to Alpine.

Byron merged commit 14066e2 into main May 28, 2024
dependabot Bot deleted the dependabot/github_actions/Vampire/setup-wsl-3.1.0 branch May 28, 2024 04:40

Byron commented May 28, 2024

Copy link
Copy Markdown
Member

Thanks everyone! I went ahead and just merged this PR, and hope it helps.

EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Jul 24, 2024
Use Alpine Linux in WSL on CI
58a9a58 
Some of the CI tests use WSL. This switches the WSL distribution
from Debian to Alpine, which might be slightly faster. For the way
it is being used here, the main expected speed improvement would be
to how long the image would take to download, as Alpine is smaller.

(The reason for this is thus unrelated to the reason for the Alpine
docker CI test job added in gitpython-developers#1826. There, the goal was to test on a
wider variety of systems and environments, and that runs the whole
test suite in Alpine. This just changes the WSL distro, used by a
few tests on Windows, from Debian to Alpine.)

Two things have changed that, taken together, have unblocked this:

- Vampire/setup-wsl#50 was fixed, so the
  action we are using is able to install Alpine Linux. See:
  gitpython-developers#1917 (review)

- gitpython-developers#1893 was fixed in gitpython-developers#1888. So if switching the WSL distro from
  Debian to Alpine breaks any tests, including by making them fail
  in an unexpected way that raises the wrong exception, we are
  likely to find out.
EliahKagan mentioned this pull request Jul 24, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Byron Byron left review comments
EliahKagan EliahKagan approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL