FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow relative path url in submodules for submodule_update by t-webber · Pull Request #2062 · gitpython-developers/GitPython · GitHub

/ GitPython Public

Allow relative path url in submodules for submodule_update - #2062

Merged
Byron merged 2 commits into
gitpython-developers:mainfrom
t-webber:relative_path_submodules
Jul 24, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Allow relative path url in submodules for submodule_update#2062
Byron merged 2 commits into
gitpython-developers:mainfrom
t-webber:relative_path_submodules

Conversation

t-webber commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

fixes #944

t-webber force-pushed the relative_path_submodules branch from 545618e to ec2e2c8 Compare July 22, 2025 10:27
Byron requested changes Jul 23, 2025
View reviewed changes

Byron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks a lot for contributing!

I think with a test this can be merged. Maybe looking at the existing tests for submodules can help to set one up.

Thanks again.

t-webber requested a review from Byron July 23, 2025 05:25
Byron approved these changes Jul 24, 2025
View reviewed changes

Byron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks a lot, this is great!

Something I'd like to also know is what happens if the submodule is 'hidden', and the URL starts with a .. This would mean the submodule resides within the parent repository, but is added as submodule under a different path.
Is this is a thing even? If you think so, please do feel free to contribute the respective test as well, but let's not block this PR on such an edge-case.

Byron merged commit bbb3d00 into gitpython-developers:main Jul 24, 2025
27 checks passed

t-webber commented Jul 24, 2025

Copy link
Copy Markdown
Contributor Author

I am not sure I understand your question.

When you run git add ../../other/repo without specifying the path, git adds a default of repo as path in .gitmodules, so still in the same folder.

If you try and remove the path argument, you get an error when trying to update the submodule. You have the same error if the submodule has an absolute path. Git seems to always want a path and a URL field in the .gitmodules file.

t-webber deleted the relative_path_submodules branch July 24, 2025 06:32

Byron commented Jul 24, 2025

Copy link
Copy Markdown
Member

Please don't mind it, it's not too important I think.

Thanks again for contributing this fix and a test🙏.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Byron Byron approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

submodule update doesn't work with relative submodule paths (in GitPython 2.1.14)

2 participants

Back | FazBrowse Home | New Git URL