| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@EliahKagan It looks like this update is a breaking change to WSL, and I also don't know how much we want it. |
Sorry, something went wrong.
There was a problem hiding this comment.
@EliahKagan It looks like this update is a breaking change to WSL, and I also don't know how much we want it.
TL;DR: This should be easy to fix and it's a good update to take once we slightly adjust our CI workflow to adapt to it, but I haven't rushed to do it since I think it makes sense to do it at the same time as some other changes.
The improvements to Vampire/setup-wsl since the version we're currently using actually include a fix for Vampire/setup-wsl#82, which I had reported, as it relates to #2107 and #2108 here. Alpine had started always giving a 403 error on download.
Even if we stick with Debian, I think we'll still want the upgrade, because if I understand correctly, in the version of the action we're currently on, Debian is affected by a different but related bug that kept it from getting current packages (Vampire/setup-wsl#76, Vampire/setup-wsl#85). In both cases, the underlying broad cause is that some distros can only be obtained reliably by methods that require they be specified with a version number, and lack a reliable and correct way to get them without specifying a version.
The CI failures here can be fixed by specifying the Debian version or, perhaps better, by no longer specifying the distro at all--since I think, from this point on and for a while, the default distro and version is likely to be reasonable for our purposes. Also, because Debian now has to be specified versioned, the action's default distro itself specifies it versioned, with the default version changing only when the action is upgraded. So the version of Debian we're using shouldn't drift at unexpected times. There's an intermediate version between what we're using and this version, where CI wouldn't fail, because the way we're specifying Debian is deprecated but not removed. But to get the main benefit, we'd have to stop specifying it that way anyway.
I've been meaning to make the changes described above, but I figured it would make sense to do it at the same time as dependabot.yml is edited to no longer allow beta ecosystems, as that's no longer required for pre-commit updates; and to add a 7-day cooldown for ecosystems that support it, which I think, of those we use here, is only github-actions. The cooldown period might also make it so this action wouldn't come in until a little later, which is another reason I haven't rushed to integrate this PR--we might end up taking the above-mentioned intermediate version first. When making these changes, it would also make sense to pin actions to full OIDs, which is a good thing in and of itself and also increases the benefit conferred by cooldown.
However, I have no objection to these things being done at different times or in a different order. (If you think some should not be done at all, please let me know, since I might otherwise proceed to do them.)
Sorry, something went wrong.
That's great to hear, no rush then. |
Sorry, something went wrong.
Bumps [Vampire/setup-wsl](https://github.com/vampire/setup-wsl) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/vampire/setup-wsl/releases) - [Commits](Vampire/setup-wsl@v6.0.0...v7.0.0) --- updated-dependencies: - dependency-name: Vampire/setup-wsl dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Converting to draft while we know this needs fixing. |
Sorry, something went wrong.
|
Thanks. I should have this in soon. I very much agree with it being marked draft right now. |
Sorry, something went wrong.
|
@EliahKagan a word of warning: I let an agent loose on this PR, clearly marked, so you can see one version of a fix when you intend to work on it. Of course, ideally the agent will do the right thing and it can be merged without consuming much of your time at all. |
Sorry, something went wrong.
|
I think the solution is just to remove the operating system specification altogether. It defaults to Debian-13 according to the release notes here, which is a better choice than the Debian-11 the agent seems to have guessed. We don't need to specify the operating system because we're using Debian and the action is now tracking reasonable recent or latest stable Debian major versions as the default distro. If we want a specific version, we should pin the action itself to a patch version as we seem already to be doing or, far far better, a full SHA. That's actually something we should do on all actions, pinning to a full SHA, and enforce with CodeQL and Zizmor, plus at least a week cool down period, like we do in gitoxide. But agents run a risk of confabulating OIDs, and in any case OIDs should always be set mechanistically. The agent can be instructed to set them using pinact. That outputs the syntax that is both fully pinned and understood by Dependabot. This could be done in this PR but I'd suggest doing it separately. |
Sorry, something went wrong.
setup-wsl v7 removes the deprecated unversioned Debian distribution, causing every Windows matrix job to stop during environment setup. Select Debian-13 implicitly, the documented replacement for the old Debian identifier, to preserve the workflow environment while allowing the action upgrade. Co-authored-by: Eliah Kagan <degeneracypressure@gmail.com>
|
Thanks @EliahKagan! I have done that and this PR will merge if CI passes with Debian 13 (implicit). |
Sorry, something went wrong.
There was a problem hiding this comment.
This PR updates the GitHub Actions workflow to use Vampire/setup-wsl v7.0.0, aligning the CI environment with the latest major release of the WSL setup action.
Changes:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Bumps Vampire/setup-wsl from 6.0.0 to 7.0.0.
Release notesSourced from Vampire/setup-wsl's releases.
... (truncated)
CommitsYou can trigger a rebase of this PR by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: