Repository navigation
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts a regression test to be resilient to Python interpreter startup latency, so it validates GitPython’s kill_after_timeout behavior rather than intermittently failing due to a too-aggressive deadline. Production code is unchanged.
Changes:
- Increased kill_after_timeout in test_it_honors_kill_after_timeout_with_output_stream from 0.1s to 1s to reduce flakiness and better target the intended behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
The macOS Python 3.8 Actions job intermittently killed the helper process before it could start and flush its expected output. The 100 ms deadline tested interpreter startup speed rather than GitPython timeout behavior. Keep the timeout regression coverage while allowing one second for process startup. Validation: five focused runs with Python 3.8; Ruff check and format. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.
Everything below this line was generated by Codex.
Created by Codex on behalf of Byron. Byron will review before this is ready to merge.
Reported issue
$issue-full-auto https://github.com/gitpython-developers/GitPython/actions/runs/30193022939/job/89769540615 fails as flake, and only that. Fix it one way or another, exluding it is also fine if there is no alternative.
Change
Increase the timeout regression test deadline from 100 ms to one second so it tests GitPython timeout behavior instead of Python interpreter startup speed. Production code is unchanged.
Validation