Pull request overview

This PR updates GitPython’s Windows path handling to account for Python 3.13+ changes (notably around drive-rooted paths), expands coverage across config/includes, index/submodule path confinement, and adjusts CI/tox + tests to validate newer Python versions and avoid assumptions about a local master branch.

Changes:

• Introduces shared path-kind and confinement helpers and uses them in index/submodule path normalization.
• Updates conditional include matching to normalize gitdir patterns to Git-style separators and improves repository confinement checks.
• Expands/adjusts test suite for Windows path kinds and removes reliance on a master branch; enables Python 3.13–3.15 in tox and CI.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

git/refs/symbolic.py:123

• On Windows, comparing common_path and base_path with raw string equality can incorrectly reject valid paths when only casing differs (case-insensitive filesystem) or when realpath() normalizes the drive letter. Previously this check used normcase() to avoid false positives; removing it can make _get_validated_path raise ValueError for refs that are actually inside the repo.

        base_path = os.path.realpath(os.fspath(base))
        abs_path = os.path.realpath(os.path.join(base_path, path))
        try:
            common_path = os.path.commonpath([base_path, abs_path])
        except ValueError as e:
            raise ValueError("Reference path %r escapes the repository" % path) from e
        if common_path != base_path:
            raise ValueError("Reference path %r escapes the repository" % path)

git/util.py:363

• _to_relative_path() claims to resolve drive-rooted paths like \\dir against the drive of root, but abspath(join(root_abs, path_str)) drops the drive and then resolves against the process current drive. If root is on a different drive than the current working directory, \\dir will be resolved to the wrong drive, and confinement checks will be incorrect.

    root_abs = osp.abspath(os.fspath(root))
    path_abs = osp.abspath(osp.join(root_abs, path_str))
    try:

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

git/index/base.py:660

• This method can now raise :exc:InvalidGitRepositoryError (bare repo + rooted/drive path), but the docstring only mentions :exc:ValueError. Please document the additional exception so error handling is discoverable from the API contract.

        :raise ValueError:
        """

git/objects/submodule/base.py:381

• The docstring says ValueError is only raised when the path is outside the working tree, but the implementation also rejects paths that refer to the working tree root (".") after normalization. Documenting that behavior will make this constraint clearer.

        :raise ValueError:
            If path is not contained in the parent repository's working tree.

git/index/base.py:666

• The docstring above still describes this as making paths relative to the repo's "git directory", but the new implementation delegates to git.util._to_relative_path(..., working_tree_dir) and returns a Git-style (forward-slash) path. Please update the return description so it matches the current behavior.

        return _to_relative_path(cast(PathLike, self.repo.working_tree_dir), path)

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.