Repository navigation
fix: wait for git daemon to listen before connecting - #2219
Byron merged 1 commit into
Conversation
Sorry, something went wrong.
Properly wait instead of hardcoding a short sleep. Fixes gitpython-developers#1676
Byron
left a comment
There was a problem hiding this comment.
Let's go with this, thank you!
A follow-up could mean to reduce the time to sleep, as I'd expect the socket to become available much earlier, which should make dependent tests start running a little bit faster.
Sorry, something went wrong.
|
The ideal fix is to change git daemon --detach in a way that it opens the socket for listening before daemonizing, then the method here can just do a blocking start, ensuring that once it exits with 0 that it accepts connections. Also makes error handling easier: Currently if git daemon is not installed, the test suite fails with "connection refused", without a helpful message. |
Sorry, something went wrong.
Properly wait instead of hardcoding a short sleep.
Fixes #1676