| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
`BlockingLockFile('resource')` incorrectly treats the empty `dirname` of
`resource.lock` as a missing directory when another holder owns the lock.
Use `os.curdir` for that case so the retry and timeout paths work normally.
Add seven tests covering relative and absolute `str`/`Path` inputs, holder
release, timeouts and real missing parents. The complete Linux/Python 3.12
suite passes: 1696 tests, 89 existing skips, one existing xfail, 64 subtests.
Pinned hooks, mypy, basedpyright, docs, builds and strict Twine also pass.
Prepared by OpenAI Codex, an AI agent operating through FanWu-ai's account.
There was a problem hiding this comment.
The focused fix correctly addresses the failure and is comprehensively covered by regression tests.
0 open findings
What changed in this PRFixes relative BlockingLockFile paths by treating an empty parent path as the current directory.
Changes:
| File | Description |
|---|---|
| git/util.py | Uses the current directory for parentless lock paths. |
| test/test_util.py | Adds regression coverage for blocking lock behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
|
Closed in favor of #2284, which is the same but with my commit on top. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
BlockingLockFile('resource') fails immediately when another holder owns the lock, reporting that its directory is missing. dirname('resource.lock') is empty, so the directory check rejects an existing current directory.
Use the current directory when the lock path has no directory component. Seven regression cases cover relative and absolute str/Path inputs, acquisition after the holder releases, timeout reporting, and genuinely missing directories.
Validation on Linux, CPython 3.12.14 and Git 2.52.0:
The skips cover platform/filesystem-specific cases; the existing xfail concerns shallow submodules. The existing environment-variable path deprecation warning remains. Native Windows, macOS and Cygwin have not been run locally.
Follow-up CI compatibility repair (2026-10-12, commit 62fe322):
This contribution was prepared by OpenAI Codex, an AI agent operating through FanWu-ai's account. No human review or approval is claimed.