FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replace GIT_SSH with GIT_SSH_COMMAND for SSH key management. by teeberg · Pull Request #256 · gitpython-developers/GitPython · GitHub

Repository navigation

Replace GIT_SSH with GIT_SSH_COMMAND for SSH key management. - #256

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
teeberg:master
Apr 8, 2015
Merged

Byron merged 1 commit into
gitpython-developers:masterfrom
teeberg:master

Conversation

teeberg commented Feb 9, 2015

Copy link
Copy Markdown
Contributor

Also move untestable documentation out of test.

Related: #234, #242

Also move untestable documentation out of test.

Related: #234, #242

teeberg commented Feb 9, 2015

Copy link
Copy Markdown
Contributor Author

I actually think it's a really cool idea to test the documentation like this, but if you have to say that we don't actually make the call because the test setup won't allow us to, I'd rather remove it from the test... :-)

Byron commented Feb 10, 2015

Copy link
Copy Markdown
Member

Thank you ! I wouldn't mind putting in the example in clear-text in this case.
However, as GitPython aims to support multiple different versions of the git commandline program, it would be great to keep both versions, stating which git --version you require to make use of either one.
Do you think you can make this change for me so I can make the merge ?
Thanks in advance

Byron commented Apr 7, 2015

Copy link
Copy Markdown
Member

I'd like to make a new release this week, and would be glad if I could merge this PR. Can you have a look at my previous request ? It shouldn't take long. If you have no time for this just let me know and I will do it for you.
Thanks

Byron merged commit 158bc98 into gitpython-developers:master Apr 8, 2015
Byron added a commit that referenced this pull request Apr 8, 2015
It goes along with the new one advertising the GIT_SSH_COMMAND
environment variable.

Related to #256
Byron added a commit that referenced this pull request Apr 8, 2015
They didn't show up as code-block

Related to #256

Byron commented Apr 8, 2015

Copy link
Copy Markdown
Member

You can watch the development stream on youtube.

teeberg commented Apr 8, 2015

Copy link
Copy Markdown
Contributor Author

Thanks for taking over. :-) I was willing to do it, but I'm indeed rather busy and it probably takes you way less time.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL