import OrderedDict from git.odict rather than directly from collections, to pix Py2.6 compatibility - #443
Merged
Byron merged 1 commit intoMay 26, 2016
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ns, to pix Py2.6 compatibility
Copy link
Copy Markdown
Member
|
The unit-tests are not perfectly isolated, and being on a branch makes some of them fail. It's a known issue, also one that I am not proud of :). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cfr. https://github.com/gitpython-developers/GitPython/pull/431/files/89ade7bfff534ae799d7dd693b206931d5ed3d4f#r64649040
cc @Byron
I tested this in my fork on Travis; I'm running into one failing test, but it seems unrelated to this change.
Am I missing something to make the tests pass?
====================================================================== ERROR: test_init_repo_object (git.test.test_docs.Tutorials) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/build/boegel/GitPython/git/ext/gitdb/gitdb/test/lib.py", line 87, in wrapper return func(self, path) File "/home/travis/build/boegel/GitPython/git/test/test_docs.py", line 68, in test_init_repo_object assert repo.refs['origin/master'] == repo.remotes.origin.refs.master # ... remotes ... File "/home/travis/build/boegel/GitPython/git/util.py", line 684, in __getitem__ raise IndexError("No item found with id %r" % (self._prefix + index)) IndexError: No item found with id 'origin/master'