Repository navigation
BF: allow for other section names which start with a string "remote" - #517
Merged
Byron merged 1 commit intoSep 24, 2016
Merged
Byron merged 1 commit into
Byron merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
by demanding a space after a word remote, and space is explicitly described as
a delimiter in man git-config:
To begin a subsection put its name in double quotes, separated by space from the section name,
otherwise e.g.
File "/usr/lib/python2.7/dist-packages/datalad/support/gitrepo.py", line 836, in get_remote_branches
for remote in self.repo.remotes:
File "/home/yoh/deb/gits/python-git/git/repo/base.py", line 271, in remotes
return Remote.list_items(self)
File "/home/yoh/deb/gits/python-git/git/util.py", line 745, in list_items
out_list.extend(cls.iter_items(repo, *args, **kwargs))
File "/home/yoh/deb/gits/python-git/git/remote.py", line 453, in iter_items
raise ValueError("Remote-Section has invalid format: %r" % section)
ValueError: Remote-Section has invalid format: u'remotes'
Copy link
Copy Markdown
Member
|
Thank you ! This is my first single-character PR too :) ! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by demanding a space after a word remote, and space is explicitly described as
a delimiter in man git-config:
To begin a subsection put its name in double quotes, separated by space from the section name,
otherwise e.g.
File "/usr/lib/python2.7/dist-packages/datalad/support/gitrepo.py", line 836, in get_remote_branches for remote in self.repo.remotes: File "/home/yoh/deb/gits/python-git/git/repo/base.py", line 271, in remotes return Remote.list_items(self) File "/home/yoh/deb/gits/python-git/git/util.py", line 745, in list_items out_list.extend(cls.iter_items(repo, *args, **kwargs)) File "/home/yoh/deb/gits/python-git/git/remote.py", line 453, in iter_items raise ValueError("Remote-Section has invalid format: %r" % section) ValueError: Remote-Section has invalid format: u'remotes'More proper fix I guess could be making a helper function to split any section definition into (section, subsection) tuple and use it throughout the code, since I am afraid there might be similar treatment for other common subsection names