Support Cygwin's Git on Windows by ankostis · Pull Request #533 · gitpython-developers/GitPython · GitHub

Add 2 more Appveyor matrix-combinations for Cygwin, and hide 2+2 (see below) TCs failing - you have to check from time to time if they hve been fixed.
Add git.util.cygpath() & git.util.decygpath() based on material from these 2 resources:
+https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx
+https://www.cygwin.com/cygwin-ug-net/using.html#unc-paths
Fix launching of MINGW's git-daemon also for Cygwin - reqork it as resource-managed (with statement.
"Polish" some urls sent to git commands to inlude '/cygdrive/...' prefix.
de-cygpathize repo-paths when creating git.Repo() instances to accept also '/cygdrive/...' paths.

Appveyor Cygwin TC failures

Reporting changes in the Appvayor cygwin-combination bottom-line for significant commits, in reverse chronological order:

5962373: cygwin, appveyor, Support Cygwin's Git on Windows #533: Enable actual failures, hide certain 2+2 cases
- PY2: skip: 12
- PY3: skip: 16
b2efa1b: cygwin, Support Cygwin's Git on Windows #533: FIX submodules detection (~10TCs fixed)
- PY2: err: 2, fail: 1
- PY3: err: 2, fail: 1
9afebf67: cygwin, Support Cygwin's Git on Windows #533: FIX submodules detection (~10TCs fixed)
- PY2: err: 2, fail: 2
- PY3: err: 2, fail: 2
a2d248b: cygwin, Support Cygwin's Git on Windows #533: polish abs-paths in git add commands
- PY2: err: 12, fail: 2
- PY3: err: 11, fail: 2
3b1cfcc: cygwin, Fix "known" Windows errored test cases #525: Allow '/cygdrive/c/' paths on repo init
- PY2: err: 13, fail: 2
- PY3: err: 12, fail: 2
57d0537: cygwin, Fix "known" Windows errored test cases #525: Polish also --git-separate-dir
- PY2: err: 13, fail: 3
- PY3: err: 12, fail: 3
0bce7cc: cygwin, Fix "known" Windows errored test cases #525: FIX daemon launching
- PY2: err: 13, fail: 3
- PY3: err: 12, fail: 3
e6e23ed: cygwin, Fix "known" Windows errored test cases #525: Try to make it work with Cygwin's Git.
- PY2: err: 14, fail: 3
- PY3: err: 13, fail: 3
ba7c2a0: appveyor, Fix "known" Windows errored test cases #525: enable CYGWIN TCs without failing (START: no Cygwin specific code)
- PY2: err: 44, fail: 0
- PY3: err: 13, fail: 0

- Cygwin TCs failing (start, no Cygwin specific code): - PY2: err: 44, fail: 0 - PY3: err: 13, fail: 0

+ Make `Git.polish_url()` convert paths into Cygwin-friendly paths. + Add utility and soe TCs for funcs for detecting cygwin and converting abs-paths to `/cygdrive/c/...`. - Cygwin TCs failing: - PY2: err: 14, fail: 3 - PY3: err: 13, fail: 3

+ Rework git-daemon launching with `with` resource-management. + cmd: add `is_cygwin` optional override kwd on `Git.polish_url()`. - Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3

- Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3

…init - Cygwin TCs failing: - PY2: err: 13, fail: 2 - PY3: err: 12, fail: 2

Current coverage is 94.33% (diff: 93.65%)

Merging #533 into master will decrease coverage by 0.08%

@@             master       #533   diff @@
==========================================
  Files            63         63          
  Lines          9736       9872   +136   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           9193       9313   +120   
- Misses          543        559    +16   
  Partials          0          0

Powered by Codecov. Last update 9e4a454...cc77e6b

+ Modify TCs - no main-code changes. + FIXed: + `TestSubmodule.test_git_submodules_and_add_sm_with_new_commit()` + TestDiff.test_diff_with_staged_file() - Cygwin TCs failing: - PY2: err: 11, fail: 2 - PY3: err: 10, fail: 2

+ Decygpath sm's `.git` file contents.

+ Modify TCs - no main-code changes. + FIXed: + `TestSubmodule.test_git_submodules_and_add_sm_with_new_commit()` + TestDiff.test_diff_with_staged_file() - Cygwin TCs failing: - PY2: err: 12, fail: 2 - PY3: err: 11, fail: 2

+ Use environment-markers in requirement files (see http://stackoverflow.com/a/33451105/548792).

…xed) + Decygpath sm's `.git` file contents. - Cygwin TCs failing: - PY2: err: 2, fail: 2 - PY3: err: 2, fail: 2

…xed) + Decygpath sm's `.git` file contents. + Polish another path in `git add`; actually no main-code changes, just a replace \-->/ on a relative(!) path to make cygwin-git to work. - REGRESSION `test_git_submodules_and_add_sm_with_new_commit` asks for user/email settings. - Cygwin TCs failing: - PY2: err: 2, fail: 1 - PY3: err: 2, fail: 1

…esurogates

…ide certain 2+2 cases

@Byron you may merge this one, I'm done with Windows, and franky I'm exhausted.
The CHANGES for a "Windows" version are summarized in the OPs of #519, #525 and this issue.

I would appreciate if you tried to make an even better summary and add them into CHANGES, to get an overview of my changes needed for making Windows work.

@ankostis Thanks for the hint ! I just pushed the merge-commit, bringing in all the goodness you have been working on. Thanks so much for all the work you put in, GitPython is so much better now.
I will go ahead and try to make the summary for the changes.rst file.

A new release was made. As I felt incapable of summing up the details of the changes concisely, except for general bits about unicode handling and context managers. Thus I ended up praising you, and linked to the respective milestone, hoping that this is alright with you :).

ankostis added 5 commits October 14, 2016 17:43

appveyor, gitpython-developers#533 : enable CYGWIN TCs without failing

ba7c2a0

- Cygwin TCs failing (start, no Cygwin specific code): - PY2: err: 44, fail: 0 - PY3: err: 13, fail: 0

cygwin, gitpython-developers#533 : FIX daemon launching

0bce7cc

+ Rework git-daemon launching with `with` resource-management. + cmd: add `is_cygwin` optional override kwd on `Git.polish_url()`. - Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3

cygwin, gitpython-developers#533 : Polish also --git-separate-dir

57d0537

- Cygwin TCs failing: - PY2: err: 13, fail: 3 - PY3: err: 12, fail: 3

cygwin, gitpython-developers#533 : Allow '/cygdrive/c/' paths on repo …

3b1cfcc

…init - Cygwin TCs failing: - PY2: err: 13, fail: 2 - PY3: err: 12, fail: 2

Byron added the in progress label Oct 14, 2016

ankostis added tag.Windows tag.cygwin labels Oct 15, 2016

ankostis self-assigned this Oct 15, 2016

ankostis added this to the v2.1.0 - proper windows support milestone Oct 15, 2016

ankostis force-pushed the cygwin branch from d8fc2e4 to efbedff Compare October 16, 2016 00:23

ankostis added a commit to ankostis/GitPython that referenced this pull request Oct 16, 2016

cygwin, gitpython-developers#533 : FIX submodules detection

7fa6a8d

+ Decygpath sm's `.git` file contents.

ankostis added 4 commits October 16, 2016 02:45

src: import os.path as osp

0210e39

src: reduce needless deps to gitdb.util

b02662d

ci, deps: no PY26, ddt>=1.1.1, CIs pip install test-requirements

4486bcb

+ Use environment-markers in requirement files (see http://stackoverflow.com/a/33451105/548792).

ankostis force-pushed the cygwin branch from efbedff to 997ea34 Compare October 16, 2016 00:56

ankostis added a commit to ankostis/GitPython that referenced this pull request Oct 16, 2016

cygwin, gitpython-developers#533 : FIX submodules detection (~10TCs fi…

997ea34

…xed) + Decygpath sm's `.git` file contents. - Cygwin TCs failing: - PY2: err: 2, fail: 2 - PY3: err: 2, fail: 2

ankostis added 2 commits October 16, 2016 03:04

Merge with gitpython-developers#532 , fix unicode filenames with escap…

ec731f4

…esurogates

ankostis added a commit to ankostis/GitPython that referenced this pull request Oct 16, 2016

cygwin, appveyor, gitpython-developers#533 : Enable actual failures, h…

8bdf92e

…ide certain 2+2 cases

ankostis added a commit to ankostis/GitPython that referenced this pull request Oct 16, 2016

cygwin, appveyor, gitpython-developers#533 : Enable actual failures, h…

06fa996

…ide certain 2+2 cases

ankostis added a commit to ankostis/GitPython that referenced this pull request Oct 16, 2016

cygwin, appveyor, gitpython-developers#533 : Enable actual failures, h…

4198593

…ide certain 2+2 cases

cygwin, appveyor, gitpython-developers#533 : Enable actual failures, h…

5962373

…ide certain 2+2 cases

ankostis force-pushed the cygwin branch from 997ea34 to 5962373 Compare October 16, 2016 20:20

ankostis added 2 commits October 17, 2016 11:37

helper: minor fix prefix of temp-dirs

08e0d5f

tc-helper: fix minor contexlib abuse

cc77e6b

Byron merged commit cc77e6b into gitpython-developers:master Oct 22, 2016

Byron removed the in progress label Oct 22, 2016

msiemens mentioned this pull request Nov 3, 2016

Problems under cygwin with out of tree repository msiemens/PyGitUp#31

Closed

EliahKagan mentioned this pull request Mar 31, 2024

Fix typo in _get_exe_extensions PATHEXT fallback #1890

Merged

This was referenced May 28, 2025

use sys.platform == "cygwin" to figure out when we are using cygwin #2027

Closed

correctly handle uname-cmd that doesn't point to an executable file #2026

Merged

Support Cygwin's Git on Windows by ankostis · Pull Request #533 · gitpython-developers/GitPython · GitHub

Repository navigation

Support Cygwin's Git on Windows - #533

Support Cygwin's Git on Windows#533
Byron merged 14 commits into
gitpython-developers:masterfrom
ankostis:cygwin

ankostis commented Oct 14, 2016 •
edited
Loading

Uh oh!

Uh oh!

codecov-io commented Oct 14, 2016 •
edited
Loading

Uh oh!

Uh oh!

ankostis commented Oct 16, 2016

Uh oh!

Byron commented Oct 22, 2016

Uh oh!

Byron commented Oct 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Support Cygwin's Git on Windows by ankostis · Pull Request #533 · gitpython-developers/GitPython · GitHub

Repository navigation

Support Cygwin's Git on Windows - #533

Support Cygwin's Git on Windows#533Byron merged 14 commits intogitpython-developers:mastergitpython-developers/GitPython:masterfrom ankostis:cygwinankostis/GitPython:cygwinCopy head branch name to clipboard

Conversation

ankostis commented Oct 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Appveyor Cygwin TC failures

Uh oh!

codecov-io commented Oct 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 94.33% (diff: 93.65%)

Uh oh!

ankostis commented Oct 16, 2016

Uh oh!

Byron commented Oct 22, 2016

Uh oh!

Byron commented Oct 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Support Cygwin's Git on Windows#533
Byron merged 14 commits into
gitpython-developers:masterfrom
ankostis:cygwin

ankostis commented Oct 14, 2016 •
edited
Loading

codecov-io commented Oct 14, 2016 •
edited
Loading