Allow for setting git options, that are persistent across subcommand calls - #536
Merged
ankostis merged 3 commits intoOct 19, 2016
Merged
ankostis merged 3 commits into
ankostis merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Current coverage is 94.45% (diff: 100%)@@ master #536 diff @@
==========================================
Files 63 63
Lines 9736 9749 +13
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 9193 9208 +15
+ Misses 543 541 -2
Partials 0 0
|
Sorry, something went wrong.
ankostis
reviewed
Oct 19, 2016
Comment thread
git/test/test_git.py
Outdated
|
|
||
| # reset to empty: | ||
| self.git.set_persistent_git_options() | ||
| self.assertRaises(GitCommandError, self.git.NoOp) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A minor flake8 reported by travis: ./git/test/test_git.py:175:43: E241 multiple spaces after ','
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Right, forgot this one. Thanks.
Sorry, something went wrong.
Closed
Copy link
Copy Markdown
Member
|
@bpoldrack Thanks a lot for your contribution ! I am doing maintenance today, and am confident to manage to put out a new release as well. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently _git_options in class Git are reset after each subcommand call. While this is appropriate in most cases, I'm in need to have options for the git executable, that are used with all calls to git on a certain repository and I can't provide this option for each and every call. Therefore I'd like to introduce the possibility to persistently set such options for a given instance of Git.
This is my first PR here, so I'm not exactly sure, what you want me to provide. CONTRIBUTING.md reads: "Write a test that fails unless your patch is present."
Where am I supposed to put such a test?
Just add it to git/test/test_git.py?