FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

detect renames in "git diff --raw" output by Pfiver · Pull Request #62 · gitpython-developers/GitPython · GitHub

Repository navigation

detect renames in "git diff --raw" output - #62

Merged
Byron merged 2 commits into
gitpython-developers:masterfrom
Pfiver:p2000
Jun 16, 2012
Merged

Byron merged 2 commits into
gitpython-developers:masterfrom
Pfiver:p2000

Conversation

Pfiver commented Jun 15, 2012

Copy link
Copy Markdown

potentially fixes #36

Byron commented Jun 16, 2012

Copy link
Copy Markdown
Member

Thank you.
Can you please add/update the test suite to verify it is working ?

Pfiver commented Jun 16, 2012

Copy link
Copy Markdown
Author

The tests are passing. However, I had to temporarily add

   @classmethod
   def setup_class(cls):
           cls.setUpAll()

to the TestDiff class. Otherwise I get an
"AttributeError: 'TestDiff' object has no attribute 'rorepo'" for every test
Any clues on that? What version of nose are you using? I'm using nose 1.1.2 atm.

Byron commented Jun 16, 2012

Copy link
Copy Markdown
Member

I use nosetests version 1.0.0, but I would wonder why they change the API in such a manner that causes tests to break.
Can you also add a diff output containing a rename, and add it to the test suite ?

Pfiver commented Jun 16, 2012

Copy link
Copy Markdown
Author

I have added https://github.com/P2000/GitPython/blob/p2000/git/test/fixtures/diff_rename_raw
and https://github.com/P2000/GitPython/blob/p2000/git/test/fixtures/diff_rename
has been already there. Both are in use in git.test.test_diff.TestDiff

Not sure what you mean otherwise?

The nosetest incompatibilites are probably based on different python versions then.
I have been using cpython 2.7 before and now tried with 2.6.
Some tests are still failing but most work now.
What python version are you using?

"$ nosetests": http://sprunge.us/WZYB
"$ nosetests git/test/test_diff.py": http://sprunge.us/GcSf

Byron commented Jun 16, 2012

Copy link
Copy Markdown
Member

I am using python 2.4 to 2.6, these are the versions I am testing with at least.
Besides that, you can ignore the errors I believe, as they relate to a package you have not installed. Of course, these tests should detect that and be skipped automatically, but its not related to this issue.

The master branch is heavily WIP, even though its stale for a while now. Branch 0.3 is the one most people would be using, I wouldn't think that master is in any way ready for production, at least I am not using it in production either.

As there already seem to be rename tests, it should be okay to just merge it in.
Thanks for your effort !

Byron added a commit that referenced this pull request Jun 16, 2012
detect renames in "git diff --raw" output
Byron merged commit 864cf1a into gitpython-developers:master Jun 16, 2012

Pfiver commented Jun 16, 2012

Copy link
Copy Markdown
Author

thanks for merging!

govtech42 pushed a commit to mirror81/GitPython that referenced this pull request Jul 25, 2026
…p-cfg-because-it-dropped-python-2-support

Remove setup.cfg to have a pure python wheel
govtech42 pushed a commit to mirror81/GitPython that referenced this pull request Jul 25, 2026
…dependabot/github_actions/actions/checkout-5

Bump actions/checkout from 4 to 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Do diffs detect renamed files properly?

2 participants


Back | FazBrowse Home | New Git URL