| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -139,7 +139,7 @@ def repo_creator(self): | |
| try: | ||
| try: | ||
| return func(self, rw_repo) | ||
| except: | ||
| except: # noqa E722 | ||
| log.info("Keeping repo after failure: %s", repo_dir) | ||
| repo_dir = None | ||
| raise | ||
| Expand Down Expand Up | @@ -227,7 +227,7 @@ def with_rw_and_rw_remote_repo(working_tree_ref): | |
| Same as with_rw_repo, but also provides a writable remote repository from which the | ||
| rw_repo has been forked as well as a handle for a git-daemon that may be started to | ||
| run the remote_repo. | ||
| The remote repository was cloned as bare repository from the rorepo, whereas | ||
| The remote repository was cloned as bare repository from the ro repo, whereas | ||
| the rw repo has a working tree and was cloned from the remote repository. | ||
|
|
||
| remote_repo has two remotes: origin and daemon_origin. One uses a local url, | ||
| Expand Down Expand Up | @@ -296,7 +296,7 @@ def remote_repo_creator(self): | |
| with cwd(rw_repo.working_dir): | ||
| try: | ||
| return func(self, rw_repo, rw_daemon_repo) | ||
| except: | ||
| except: # noqa E722 | ||
|
Comment thread
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityHow about except Exception: like elsewhere?
Sorry, something went wrong.
All reactions
|
||
| log.info("Keeping repos after failure: \n rw_repo_dir: %s \n rw_daemon_repo_dir: %s", | ||
| rw_repo_dir, rw_daemon_repo_dir) | ||
| rw_repo_dir = rw_daemon_repo_dir = None | ||
| Expand Down | ||
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityHow about except Exception: like elsewhere?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityWe could. But at this out-most level of handling execution, I thought to remain as "greedy" as possible. May be someone (among used dependencies) still manages to raise non-Exception "exceptions" up the chain from somewhere/somehow -- so I thought to remain catching them as well. In the other places it was more "specific" to not expect some complete weird stuff being thrown up. But if you insist, we could have it Exception here as well
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.