FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix encoding problems on windows with not using default encoding but … by brizjin · Pull Request #893 · gitpython-developers/GitPython · GitHub

Repository navigation

fix encoding problems on windows with not using default encoding but … - #893

Closed
brizjin wants to merge 2 commits into
gitpython-developers:masterfrom
brizjin:master
Closed

brizjin wants to merge 2 commits into
gitpython-developers:masterfrom
brizjin:master

Conversation

brizjin commented Jul 15, 2019

Copy link
Copy Markdown

Solves encoding problem on windows with using fetch, pull, push commands. It similar to issues: 332, 237, explanation of problem I found here in accepted answer. Also was encoding problem with calling repo.branches, quite simillar, file open in default locale encoding (cp-1251) for me, and getting branches names was broken.

Byron commented Jul 20, 2019

Copy link
Copy Markdown
Member

Thanks a lot for your efforts!
Unfortunately there is some breakage, maybe you can have a look.
Thank you

Byron commented Jan 6, 2021

Copy link
Copy Markdown
Member

As part of spring cleaning, I am closing this PR as it was opened more than half a year ago while still being open due to unresolved or remarks.

If this is a mistake or any other action should rather be taken, please let me know in the comments or create a new PR.
Thanks for your understanding and the work that undoubtedly went into this.

Byron closed this Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL