FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ignore fetch info if it starts with POST by medwards · Pull Request #97 · gitpython-developers/GitPython · GitHub

Repository navigation

Ignore fetch info if it starts with POST - #97

Closed
medwards wants to merge 1 commit into
gitpython-developers:0.3from
medwards:ignore-http-fetch
Closed

medwards wants to merge 1 commit into
gitpython-developers:0.3from
medwards:ignore-http-fetch

Conversation

Copy link
Copy Markdown

I haven't gotten the tests to pass, I get:

  File "/home/medwards/forks/GitPython/git/test/lib/asserts.py", line 16, in <module>
    'assert_mode_755'] + tools.__all__
AttributeError: 'module' object has no attribute '__all__'

Where tools is from from nose import tools

So that's great.

I also haven't manually tested this but based on output I copied and pasted into #94 it should at least fix my part of the problem.

medwards mentioned this pull request Feb 21, 2013

Copy link
Copy Markdown

Hi, I noticed this has been open for 4 months now - is there anything I can do to get it merged more quickly?

I seem to be running into the same problem when I try to call remote.fetch(tags=True) over HTTPS on version 0.3.2 RC1, and this looks like it would fix the problem.

Michael, I ran into the same problem when trying to run the tests but upgrading my version of nosetests solved it. I'm still getting a lot of failures, but I don't know if it's due to my local setup as earlier commits fail too.

Copy link
Copy Markdown

Actually, I'm wrong, my problem is fixed by the following two commits on the 0.3 branch, but they're not released yet...
8c2e872
0b820e6

Copy link
Copy Markdown
Author

Ah yeah, sorry, but unless my guess is off GitP is dead or near to dead. In
the end, rather than wait for 0.3 to be released (which if you look at the
timestamps could have been a long time ago) I just refactored my code to
use subprocess and commandline git. Good luck man.

On 21 June 2013 12:55, Mat notifications@github.com wrote:

Actually, I'm wrong, my problem is fixed by the following two commits on
the 0.3 branch, but they're not released yet
8c2e8728c2e872
0b820e60b820e6

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/97#issuecomment-19809633
.

Copy link
Copy Markdown

That's a shame if true, it's a great library.

I'd prefer not to mess around with subprocess if I can avoid it. My current plan is to just monkey patch that method, but I'll probably rethink that approach if it becomes more hassle than parsing command line output myself.

Byron commented Nov 19, 2014

Copy link
Copy Markdown
Member

Thank you.
This fix, by now, has already been merged using a slightly different implementation. It should be included on the latest release on pypi as well.

Byron closed this Nov 19, 2014
Byron added this to the v0.3.3 milestone Nov 19, 2014
govtech42 pushed a commit to mirror81/GitPython that referenced this pull request Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL