This repository was archived by the owner on Jul 26, 2026. It is now read-only.
Add CI test job for no-GIL (free-threaded) Python 3.13 - #122
Merged
EliahKagan merged 1 commit intoMay 30, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
See gitpython-developers/GitPython#2005. The rationale is that, while this is probably less important to do in gitdb and smmap, any failure that arises for this in GitPython would likely raise the question of whether a correspond problem has begun to occur in gitdb and smmap. (Both gitdb and smmap provide helpers used in GitPython even when the in-memory object database is not used, and failures may plausibly occur for reasons other than code changes because of the finicky nature of concurrency bugs and the potential for interactions affected by the runner image.)
EliahKagan
added a commit
to EliahKagan/smmap
that referenced
this pull request
May 30, 2025
See gitpython-developers/GitPython#2005, and gitpython-developers/gitdb#122 for rationale. In short, if the corresponding check starts to fail in GitPython, it may be useful to observe if there is a failure here as well.
EliahKagan
marked this pull request as ready for review
May 30, 2025 20:53
Copy link
Copy Markdown
Member
Author
|
It's definitely not worth force-pushing to fix the commit messages, but I've edited the title of this PR and gitpython-developers/smmap#61 to fix the terminology, with the idea that this might help people who are searching, avoid confusing, and avoid an inaccurate description in a changelog if the changelog is generated from PR titles. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See gitpython-developers/GitPython#2005.
The rationale is that, while this is probably less important to do in gitdb and smmap, any failure that arises for this in GitPython would likely raise the question of whether a correspond problem has begun to occur in gitdb and smmap. (Both gitdb and smmap provide helpers used in GitPython even when the in-memory object database is not used, and failures may plausibly occur for reasons other than code changes because of the finicky nature of concurrency bugs and the potential for interactions affected by the runner image.)