FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove Python 2 compatibility shims by Harmon758 · Pull Request #56 · gitpython-developers/gitdb · GitHub

This repository was archived by the owner on Jul 26, 2026. It is now read-only.
  1. gitpython-developers
  2. gitdb

Repository navigation

Remove Python 2 compatibility shims - #56

Merged
Byron merged 10 commits into
gitpython-developers:masterfrom
Harmon758:python-2-support-removal
Feb 17, 2020
ConversationCommits (10)ChecksFiles changed
Merged

Remove Python 2 compatibility shims#56
Byron merged 10 commits into
gitpython-developers:masterfrom
Harmon758:python-2-support-removal

Conversation

Harmon758 commented Feb 16, 2020

Copy link
Copy Markdown
Member

This PR removes and replaces Python 2 compatibility shims, since Python 2 support was dropped with c880f6b in 3.0.0:

  • Remove compat.memoryview and compat.PY3
  • Remove and replace compat.buffer and compat.to_bytes
  • Remove and replace compat.izip with zip, compat.MAXSIZE with sys.maxsize, compat.xrange with range
  • Remove and replace encoding.string_types and encoding.text_type with str
  • Remove and replace izip in TestPack

Harmon758 requested a review from Byron February 16, 2020 14:32
Harmon758 self-assigned this Feb 16, 2020
Byron approved these changes Feb 17, 2020
View reviewed changes

Byron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Absolutely fantastic, thanks so much for your work!
I will be releasing this in a moment, and publish a new version of GitPython as well with adjusted requirements.

Byron merged commit 183d1bc into gitpython-developers:master Feb 17, 2020
Harmon758 deleted the python-2-support-removal branch February 17, 2020 02:38
danieldooley mentioned this pull request Feb 18, 2020
Closed
tadeu mentioned this pull request Feb 18, 2020
Merged
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
Byron Byron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Harmon758

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL