FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bumped smmap upper bound by tmcclintock · Pull Request #68 · gitpython-developers/gitdb · GitHub

This repository was archived by the owner on Jul 26, 2026. It is now read-only.
  1. gitpython-developers
  2. gitdb

Repository navigation

Bumped smmap upper bound - #68

Merged
Harmon758 merged 1 commit into
gitpython-developers:masterfrom
tmcclintock:master
Mar 25, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Bumped smmap upper bound#68
Harmon758 merged 1 commit into
gitpython-developers:masterfrom
tmcclintock:master

Conversation

tmcclintock commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

Closes #67

Tests passed locally.

tmcclintock mentioned this pull request Mar 24, 2021
Closed
Byron suggested changes Mar 25, 2021
View reviewed changes

Byron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks a bunch!

Could you also increase the gitdb version number to something you find suitable for such a change?
My problem is that I don't really know what's going on and why things are breaking down as they do, originally @Harmon758 did tremendous work to assure of that.

Harmon758 approved these changes Mar 25, 2021
View reviewed changes

Harmon758 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Byron A patch version bump should be fine for this.

Harmon758 merged commit c5feb3d into gitpython-developers:master Mar 25, 2021

Byron commented Mar 25, 2021

Copy link
Copy Markdown
Member

Thanks, @Harmon758 , I just published v4.0.6, unfortunately along with 4.0.5 as that one was apparently still lying around locally. It's interesting to see how pypi allows overwriting/altering already published versions. Let's hope that doesn't break things.

View at:
https://pypi.org/project/gitdb/4.0.6/
https://pypi.org/project/gitdb/4.0.5/

Harmon758 commented Mar 25, 2021

Copy link
Copy Markdown
Member

v4.0.5 was already released on May 4, 2020, and you can't alter or overwrite existing releases, so I don't think anything happened with that version.

Harmon758 mentioned this pull request Mar 26, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
Byron Byron requested changes
Harmon758 Harmon758 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update requirements for smmap

3 participants

Back | FazBrowse Home | New Git URL