Fix WKWebView migration issues: sandbox entitlements and API compatibility by Copilot · Pull Request #535 · gitx/gitx · GitHub

Two runtime issues blocking WKWebView functionality:

Sandbox violations: WebContent helper process unable to read network configuration, generating console spam
API incompatibility crash: setDrawsBackground: called on WKWebView which only exists in deprecated WebView

Changes

GitX.entitlements

Added com.apple.security.network.client/server for WebContent process network access
Added file access entitlements for Git repository handling

PBCommitList.swift/h

Changed webView property type from WebView to WKWebView
Removed webView.drawsBackground = false (WKWebView is transparent by default)
Updated imports from WebKit/WebView.h to WebKit/WebKit.h

Context

WKWebView uses a multi-process architecture where the WebContent helper inherits app entitlements but requires explicit network permissions. The drawsBackground property was removed in WKWebView as background is now controlled via CSS.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

The tests are failing

The tests are failing

Fixed in commit 255998a. The issue was missing closing braces in the changeContentToCommit: method - the completion handler blocks weren't properly closed. The build should now succeed.

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

…face for subclass override Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com> Agent-Logs-Url: https://github.com/gitx/gitx/sessions/345e7155-ff35-493a-8814-1bc8e8bda07e

…ibility Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com> Agent-Logs-Url: https://github.com/gitx/gitx/sessions/657217c6-b6ea-4623-aefb-ed5f287caa05

…ound call Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com> Agent-Logs-Url: https://github.com/gitx/gitx/sessions/7886a2aa-4f08-47e0-bfc6-bfc4112ee98a

Is that even possible? Last I've checked, WKWebView wasn't exposing some of the script stuff we need… somewhere.

Copilot AI assigned Copilot and hannesa2 Mar 20, 2026

Copilot started work on behalf of hannesa2 March 20, 2026 07:09 View session

Copilot AI changed the title [WIP] Fix deprecated WebView in PBWebController Migrate from deprecated WebView to WKWebView Mar 20, 2026

Copilot AI requested a review from hannesa2 March 20, 2026 07:27

Copilot finished work on behalf of hannesa2 March 20, 2026 07:27

hannesa2 requested changes Mar 20, 2026

View reviewed changes

Copilot started work on behalf of hannesa2 March 20, 2026 07:38 View session

Copilot AI requested a review from hannesa2 March 20, 2026 07:42

Copilot finished work on behalf of hannesa2 March 20, 2026 07:42

Copilot started work on behalf of hannesa2 March 20, 2026 08:13 View session

Copilot AI changed the title Migrate from deprecated WebView to WKWebView Complete WebView to WKWebView migration: fix PBWebDiffController Mar 20, 2026

Copilot finished work on behalf of hannesa2 March 20, 2026 08:17

Copilot started work on behalf of hannesa2 March 20, 2026 08:22 View session

Copilot AI changed the title Complete WebView to WKWebView migration: fix PBWebDiffController Fix WebView API incompatibilities: windowScriptObject and mainFrame Mar 20, 2026

Copilot finished work on behalf of hannesa2 March 20, 2026 08:25

Copilot started work on behalf of hannesa2 March 20, 2026 08:34 View session

Copilot AI changed the title Fix WebView API incompatibilities: windowScriptObject and mainFrame Fix WebView to WKWebView migration build failures Mar 20, 2026

Copilot finished work on behalf of hannesa2 March 20, 2026 08:39

Copilot started work on behalf of hannesa2 March 20, 2026 09:18 View session

Copilot finished work on behalf of hannesa2 March 20, 2026 09:23

Copilot started work on behalf of hannesa2 March 20, 2026 09:53 View session

Copilot AI changed the title Fix WebView to WKWebView migration build failures Implement missing WKWebView functionality to fix empty window Mar 20, 2026

Copilot finished work on behalf of hannesa2 March 20, 2026 10:11

hannesa2 force-pushed the copilot/update-pbwebcontroller-for-wkwebview branch from ba15830 to a261737 Compare March 20, 2026 10:16

Copilot started work on behalf of hannesa2 March 20, 2026 10:17 View session

Copilot finished work on behalf of hannesa2 March 20, 2026 10:21

Copilot started work on behalf of hannesa2 March 20, 2026 10:28 View session

Copilot AI changed the title Implement missing WKWebView functionality to fix empty window Expose setupJavaScriptBridge and userContentController:didReceiveScriptMessage: for subclass override Mar 20, 2026

Copilot AI and others added 15 commits March 21, 2026 16:53

Fix missing closing braces in changeContentToCommit method

bab7e35

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Fix windowScriptObject usage in PBWebDiffController

b512b56

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Fix mainFrame usage in GLFileView

3c65e23

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Add PBGitXSchemeHandler files to Xcode project

bde81eb

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Remove backup file from repository

1395938

Fix XML tag mismatch: webPreferences -> wkPreferences

2f13a72

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Add error handling for missing HTML files in WKWebView

27def64

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Implement runCommand for WKWebView git operations

81590c9

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Add Index object stub for commit view (WKWebView)

3bd4c8f

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Update WEBKIT_MIGRATION.md with implementation status

5fe0a0e

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Fix callback parameter order in Index message handler

ac55605

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Use error-first callback pattern for Index handler consistency

c6ac1cb

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Address code review feedback: improve error handling and documentation

f91ee92

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Expose setupJavaScriptBridge in public interface for subclass override

3728c5f

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

Expose userContentController:didReceiveScriptMessage: in public inter…

e77a8b9

…face for subclass override Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>

hannesa2 force-pushed the copilot/update-pbwebcontroller-for-wkwebview branch from 879fc04 to e77a8b9 Compare March 21, 2026 15:54

Copilot started work on behalf of hannesa2 March 21, 2026 16:27 View session

Add LSMinimumSystemVersion to Info.plist for macOS 13.0 compatibility

7d1efbf

Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com> Agent-Logs-Url: https://github.com/gitx/gitx/sessions/345e7155-ff35-493a-8814-1bc8e8bda07e

Copilot AI changed the title Expose setupJavaScriptBridge and userContentController:didReceiveScriptMessage: for subclass override Add LSMinimumSystemVersion to Info.plist for system framework compatibility Mar 21, 2026

Copilot finished work on behalf of hannesa2 March 21, 2026 16:30

Copilot started work on behalf of hannesa2 March 21, 2026 16:36 View session

Add network and file access entitlements for WKWebView sandbox compat…

cc14fec

…ibility Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com> Agent-Logs-Url: https://github.com/gitx/gitx/sessions/657217c6-b6ea-4623-aefb-ed5f287caa05

Copilot AI changed the title Add LSMinimumSystemVersion to Info.plist for system framework compatibility Add entitlements for WKWebView sandbox compatibility Mar 21, 2026

Copilot finished work on behalf of hannesa2 March 21, 2026 16:38

Copilot started work on behalf of hannesa2 March 21, 2026 16:54 View session

Fix WKWebView incompatibility in PBCommitList - remove setDrawsBackgr…

e4c97be

…ound call Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com> Agent-Logs-Url: https://github.com/gitx/gitx/sessions/7886a2aa-4f08-47e0-bfc6-bfc4112ee98a

Copilot AI changed the title Add entitlements for WKWebView sandbox compatibility Fix WKWebView migration issues: sandbox entitlements and API compatibility Mar 21, 2026

Copilot finished work on behalf of hannesa2 March 21, 2026 16:57

goneng mentioned this pull request Aug 21, 2026

Clear the mechanical AppKit deprecation warnings #580

Merged

Fix WKWebView migration issues: sandbox entitlements and API compatibility by Copilot · Pull Request #535 · gitx/gitx · GitHub

Uh oh!

Fix WKWebView migration issues: sandbox entitlements and API compatibility - #535

Fix WKWebView migration issues: sandbox entitlements and API compatibility#535
hannesa2 with Copilot wants to merge 24 commits into
masterfrom
copilot/update-pbwebcontroller-for-wkwebview

Copilot AI commented Mar 20, 2026 •
edited
Loading

Uh oh!

Uh oh!

hannesa2 left a comment

Uh oh!

Copilot AI commented Mar 20, 2026

Uh oh!

tiennou commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix WKWebView migration issues: sandbox entitlements and API compatibility by Copilot · Pull Request #535 · gitx/gitx · GitHub

Uh oh!

Fix WKWebView migration issues: sandbox entitlements and API compatibility - #535

Fix WKWebView migration issues: sandbox entitlements and API compatibility#535hannesa2 with Copilot wants to merge 24 commits intomastergitx/gitx:masterfrom copilot/update-pbwebcontroller-for-wkwebviewgitx/gitx:copilot/update-pbwebcontroller-for-wkwebviewCopy head branch name to clipboard

Conversation

Copilot AI commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Context

Uh oh!

hannesa2 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 20, 2026

Uh oh!

tiennou commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix WKWebView migration issues: sandbox entitlements and API compatibility#535
hannesa2 with Copilot wants to merge 24 commits into
masterfrom
copilot/update-pbwebcontroller-for-wkwebview

Copilot AI commented Mar 20, 2026 •
edited
Loading