Support Go 1.26.4 builds - #152
Open
Eric-Guo wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Eric-Guo
marked this pull request as ready for review
June 17, 2026 15:57
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR primarily improves test portability and isolation (avoiding OS-specific paths and repo-local filesystem side effects), while also updating a few Go dependencies.
Changes:
- Make filesystem-touching tests use temp directories and OS-agnostic path joining.
- Replace ad-hoc panic recovery logic with a structured panic assertion in tracer tests.
- Bump several Go module dependencies (notably sonic and gorm) and refresh go.sum.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file| File | Description |
|---|---|
| pkg/tracer/console_test.go | Isolates file exporter tests via temp working directory and updates panic assertion logic. |
| pkg/sql2code/parser/parser_test.go | Replaces Windows-specific path string with filepath.Join for cross-platform tests. |
| pkg/sgorm/sqlite/sqlite_test.go | Writes sqlite test DB into t.TempDir() for better isolation. |
| go.mod | Updates dependency versions and adds new indirect deps required by upgrades. |
| go.sum | Syncs checksums with updated module graph. |
| .gitignore | Ignores sqlite .db files under pkg/sgorm/sqlite/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
pkg/tracer/console_test.go
Comment on lines
+33
to
+35
| assert.Panics(t, func() { | ||
| _, _, _ = NewFileExporter(t.TempDir()) | ||
| }) |
Comment thread
pkg/sql2code/parser/parser_test.go
Comment on lines
+372
to
+373
| dbFile := filepath.Join("..", "..", "..", "test", "sql", "sqlite", "sponge.db") | ||
| info, err := GetSqliteTableInfo(dbFile, "user_order") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests