Use SHA256 for SSH signing - #24
Open
42wim wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When using the SSH Agent signers we need to use a wrapper to actually allow signing with SHA256.
Copy link
Copy Markdown
Member
|
Hi, very sorry for the delay. I see the referenced issue: golang/go#37278 Is marked closed. Is this change still needed? I have no problem with a wrapper for SSH Agent signers. I am just not entirely a big fan of enabling MD4/MD5. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I'm not doing anything with md4/md5, this PR enables SHA256 for ssh signing instead of SHA1. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@cjslep please let me know if there's anything not clear |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
ping |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the SSH Agent signers we need to use a wrapper to actually
allow signing with SHA256.