Implementing the "get" function on a "Dictionary" - #106
Merged
corona10 merged 1 commit intoOct 5, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sbinet
reviewed
Sep 30, 2019
Comment thread
py/dict.go
Outdated
|
|
||
| StringDictType.Dict["get"] = MustNewMethod("get", func(self Object, args Tuple) (Object, error) { | ||
| var length = len(args) | ||
| if length == 0 { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I believe "Effective Go" recommands to use switch for these kind of if-else-if code paths:
switch {
case length == 0:
// ...
case length > 2:
// ...
}
...
Sorry, something went wrong.
sbinet
reviewed
Sep 30, 2019
sbinet
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
some nit picks, but LGTM otherwise.
Sorry, something went wrong.
Comment thread
py/dict.go
Outdated
Implement the "get" function and add unit test. fixes #105
Copy link
Copy Markdown
Contributor
Author
|
@sbinet |
Sorry, something went wrong.
corona10
approved these changes
Oct 5, 2019
corona10
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the "get" function and add unit test.
fixes #105