__ne__ of dict return NotImplemented - #109
Conversation
Sorry, something went wrong.
if type of other is not dict, return NotImplemented Fixes go-python#108
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 69.92% 70.02% +0.09%
==========================================
Files 60 60
Lines 10819 10821 +2
==========================================
+ Hits 7565 7577 +12
+ Misses 2729 2718 -11
- Partials 525 526 +1
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
@corona10 |
Sorry, something went wrong.
ncw
left a comment
There was a problem hiding this comment.
I think the code looks great! I have a minor quibble with a comment so if you could fix that then I'll merge - thank you :-)
Sorry, something went wrong.
| assert a.__eq__(3) != True | ||
| assert a.__ne__(3) != False | ||
| assert a.__ne__(3) != True | ||
| assert a.__ne__(3) != False # This part should be changed in comparison with NotImplemented |
There was a problem hiding this comment.
Can you remove this comment please? It is in the wrong place (it should be on the line above) and it refers to a bug which is fixed (or will be when this is merged) so will make no sense in the future.
The best way of making that sort of comment is to add a github comment to the review.
Sorry, something went wrong.
There was a problem hiding this comment.
Removed it. Would you like to review it again?
Sorry, something went wrong.
|
Thank you :-) We can think about more abstraction in a later PR if we want. I'll merge this now. |
Sorry, something went wrong.
if type of other is not dict,
return NotImplemented
Fixes #108