FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix bug in "items" function by Sungmin-Joo · Pull Request #115 · go-python/gpython · GitHub

/ gpython Public

Fix bug in "items" function - #115

Merged
corona10 merged 2 commits into
go-python:masterfrom
Sungmin-Joo:master
Nov 18, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Fix bug in "items" function#115
corona10 merged 2 commits into
go-python:masterfrom
Sungmin-Joo:master

Conversation

Sungmin-Joo commented Oct 6, 2019 •
edited by corona10
Loading

Copy link
Copy Markdown
Contributor

Fixes #101

codecov-io commented Oct 6, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #115 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage    72.6%   72.61%   +<.01%     
==========================================
  Files          60       60              
  Lines       11912    11915       +3     
==========================================
+ Hits         8649     8652       +3     
  Misses       2736     2736              
  Partials      527      527
Impacted Files Coverage Δ
py/dict.go 65.78% <100%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3df7a4...f64b79f. Read the comment docs.

corona10 reviewed Oct 8, 2019
View reviewed changes
Comment thread py/tests/dict.py Outdated
assert v == "b"
if k == "c":
assert v == 5.5
assertRaises(TypeError,a.items,'a')

corona10 Oct 8, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit Please follow PEP8 when you writing python code.

assertRaises(TypeError, a.items, 'a')

Sungmin-Joo commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

@corona10
Okay, I'm done with it right away.

Sungmin-Joo commented Nov 18, 2019

Copy link
Copy Markdown
Contributor Author

@corona10
I'm sorry, but can you check it again?

corona10 approved these changes Nov 18, 2019
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for the delay
LGTM

corona10 commented Nov 18, 2019

Copy link
Copy Markdown
Collaborator

@Sungmin-Joo Next time, I recommend you to work on the sperate branch rather than master branch :)

corona10 merged commit 4c28217 into go-python:master Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Found a problem with the args of the Dictionary "items" function.

3 participants

Back | FazBrowse Home | New Git URL