FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implement isinstance by xarus01 · Pull Request #122 · go-python/gpython · GitHub

/ gpython Public

Implement isinstance - #122

Merged
ncw merged 1 commit into
go-python:masterfrom
xarus01:master
Nov 5, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Implement isinstance#122
ncw merged 1 commit into
go-python:masterfrom
xarus01:master

Conversation

xarus01 commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

codecov-io commented Oct 20, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #122 into master will decrease coverage by 0.11%.
The diff coverage is 4.76%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   72.85%   72.74%   -0.12%     
==========================================
  Files          60       60              
  Lines       11949    11970      +21     
==========================================
+ Hits         8706     8707       +1     
- Misses       2709     2729      +20     
  Partials      534      534
Impacted Files Coverage Δ
builtin/builtin.go 77.53% <4.76%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c23b14...5558a8b. Read the comment docs.

corona10 requested changes Oct 20, 2019
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please rebase your branch first :)

ghost reviewed Oct 21, 2019
View reviewed changes
Comment thread builtin/builtin.go Outdated
ncw reviewed Oct 21, 2019
View reviewed changes

ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this basically looks sound :-)

I put some comments inline.

I didn't know isinstance recursively unpacked its args - who would have thought!

Comment thread builtin/builtin.go Outdated
Comment thread builtin/builtin.go Outdated
Comment thread builtin/builtin.go Outdated
Comment thread builtin/builtin.go Outdated
var res py.Bool
var class = args[1].(py.Tuple)
for idx := range class {
var new_args []py.Object

ncw Oct 21, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This would be more efficently written

var new_args = []py.Object{args[0], class[idx]}

Comment thread builtin/builtin.go Outdated
if err != nil {
return false, err
}
res = res || temp

ncw Oct 21, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should say

if res {
    return res
}

to short circuit the rest of the evaluations shouldn't it?

If you do that you can move the definition of res to here.

Comment thread builtin/builtin.go Outdated
}
res = res || temp
}
return res, nil

ncw Oct 21, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Then this can say

return false, nil

Comment thread builtin/builtin.go Outdated
}
default:
{
if args[0].Type() != py.TypeType {

ncw Oct 21, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You are checking this for every entry in the args - it would be better checked in builtin_isinstance I think.

xarus01 requested a review from corona10 October 24, 2019 08:20
ncw reviewed Oct 25, 2019
View reviewed changes

ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this looks fine now except for the spare debug!

Can you fix that, squash into one commit and force push, then I'll merge - thank you :-)

Comment thread builtin/builtin.go Outdated
corona10 requested changes Oct 26, 2019
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the contribution @xarus01

I left some nit review.
cc @ncw

Comment thread vm/tests/builtin.py Outdated
Comment thread builtin/builtin.go
xarus01 requested a review from corona10 October 30, 2019 04:10

ncw commented Nov 5, 2019

Copy link
Copy Markdown
Collaborator

I think this is looking good now - thank you :-)

Apologies for the delay!

I'll merge it now.

ncw merged commit 051f189 into go-python:master Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncw ncw left review comments
corona10 Awaiting requested review from corona10
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL