FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

builtin: Update builtin_all and builtin_any for Python3 by corona10 · Pull Request #15 · go-python/gpython · GitHub

/ gpython Public

builtin: Update builtin_all and builtin_any for Python3 - #15

Merged
sbinet merged 1 commit into
go-python:masterfrom
corona10:gh-14
Aug 31, 2018
ConversationCommits (1)ChecksFiles changed
Merged

builtin: Update builtin_all and builtin_any for Python3#15
sbinet merged 1 commit into
go-python:masterfrom
corona10:gh-14

Conversation

corona10 commented Aug 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

corona10 requested review from ncw and sbinet August 30, 2018 05:51
corona10 force-pushed the gh-14 branch 2 times, most recently from bfeae97 to c3410f1 Compare August 30, 2018 06:34

corona10 commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator Author

@sbinet

I've also fixed appveyor.yml for solving gcc issue which was happened on #13
PTAL

codecov-io commented Aug 30, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #15 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   64.43%   64.41%   -0.03%     
==========================================
  Files          55       55              
  Lines        9772     9766       -6     
==========================================
- Hits         6297     6291       -6     
  Misses       3008     3008              
  Partials      467      467
Impacted Files Coverage Δ
builtin/builtin.go 74.62% <100%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ae876...439862a. Read the comment docs.

corona10 mentioned this pull request Aug 30, 2018
Merged

sbinet commented Aug 30, 2018

Copy link
Copy Markdown
Member

perhaps create a PR with only the appveyor stuff?
(so it can be merged very quickly)

corona10 commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator Author

@sbinet
Okay I will create a new PR by today

sbinet previously approved these changes Aug 30, 2018
View reviewed changes

sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

sbinet commented Aug 30, 2018

Copy link
Copy Markdown
Member

it seems travis is in one of its bad days (it doesn't manage to find your commit...)

could you rebase on top of the latest master?
also, there's a typo in the CL:
s/refernce/reference/

sbinet dismissed their stale review August 30, 2018 13:05

travis fails

corona10 commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator Author

@sbinet PTAL

sbinet approved these changes Aug 30, 2018
View reviewed changes

sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

let's wait for @ncw as well.

corona10 commented Aug 31, 2018

Copy link
Copy Markdown
Collaborator Author

@ncw PTAL

ncw commented Aug 31, 2018

Copy link
Copy Markdown
Collaborator

I think that looks great now :-)

sbinet merged commit b55db0b into go-python:master Aug 31, 2018
corona10 deleted the gh-14 branch August 31, 2018 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbinet sbinet approved these changes
ncw Awaiting requested review from ncw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL