FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

kwarg testing (exposes bugs in py.ParseTupleAndKeywords) by drew-512 · Pull Request #151 · go-python/gpython · GitHub

/ gpython Public

kwarg testing (exposes bugs in py.ParseTupleAndKeywords) - #151

Merged
sbinet merged 2 commits into
go-python:masterfrom
drew-512:expand-kwarg-print-tests
Jan 31, 2022
ConversationCommits (2)ChecksFiles changed
Merged

kwarg testing (exposes bugs in py.ParseTupleAndKeywords)#151
sbinet merged 2 commits into
go-python:masterfrom
drew-512:expand-kwarg-print-tests

Conversation

drew-512 commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

This expands and restores testing for print with keyword args, exposing bugs in py.ParseTupleAndKeywords()

Accompanied with additional PR to merge branch hotfix-parse-kwargs

drew-512 mentioned this pull request Jan 28, 2022
Closed

codecov Bot commented Jan 29, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #151 (fdb62e7) into master (965bc08) will increase coverage by 0.01%.
The diff coverage is 78.04%.

❗ Current head fdb62e7 differs from pull request most recent head 0bb5b0b. Consider uploading reports for the commit 0bb5b0b to get more accurate results

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   74.54%   74.55%   +0.01%     
==========================================
  Files          64       64              
  Lines       11182    11191       +9     
==========================================
+ Hits         8336     8344       +8     
  Misses       2296     2296              
- Partials      550      551       +1
Impacted Files Coverage Δ
py/args.go 63.00% <78.04%> (+1.46%) ⬆️
builtin/builtin.go 79.93% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965bc08...0bb5b0b. Read the comment docs.

Drew O'Meara added 2 commits January 29, 2022 17:50
git: ignore builtins test output
09c3a1d
builtin,py: fix parsing bug in ParseTupleAndKeywords
0bb5b0b 
This CL also reduces the memory pressure of py.ParseTupleAndKeywords by
using a local bytes buffer.
sbinet approved these changes Jan 29, 2022
View reviewed changes

sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

I took the liberty of cherry-picking #152 into this PR and pushing into your branch (with slight reword of the commit messages).

could you send another PR against go-python/license adding yourself to the AUTHORS and CONTRIBUTORS files?

then I'll merge this one.

sbinet mentioned this pull request Jan 31, 2022
Merged

sbinet commented Jan 31, 2022

Copy link
Copy Markdown
Member

needs go-python/license#16

sbinet merged commit 2083f7d into go-python:master Jan 31, 2022

sbinet commented Jan 31, 2022

Copy link
Copy Markdown
Member

thanks a lot for sticking w/ us.

and welcome to go-python :)

This was referenced Feb 16, 2022
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbinet sbinet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL