Add multi context - #158
Merged
sbinet merged 6 commits intoFeb 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 74.55% 74.38% -0.18%
==========================================
Files 64 66 +2
Lines 11187 11395 +208
==========================================
+ Hits 8341 8476 +135
- Misses 2297 2352 +55
- Partials 549 567 +18
Continue to review full report at Codecov.
|
Sorry, something went wrong.
sbinet
approved these changes
Feb 7, 2022
sbinet
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sbinet
So this PR has all the py.Context stuff wrapped into it minus:
On the sync.CloseSync issue you raised in the prev thread, the intention is to ensure that multiple holders of a py.Context can all call Close() without any (future) consequences. IMO, this is congruent with multiple holders of a py.Context (and how it's annoying when ya have to ensure that only one Close() is called). People see that close code and they can feel comforted it's an interface ready for the real world. And it basically comes at no cost or allocations.
The last commit on this PR should prevent any conflicts (assuming you merge PR 156 and 157 first)
Otherwise, lmk what you'd like to add/remove to this, otherwise I'll wait for this merge and then I'll immediately submit a PR with the above items rolled into a final PR or lmk what I should separate, etc. Thanks.