Adding missing __len__ method to dict objects - #171
Merged
sbinet merged 1 commit intoMar 22, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 72.89% 72.90%
=======================================
Files 71 71
Lines 11682 11683 +1
=======================================
+ Hits 8516 8517 +1
Misses 2595 2595
Partials 571 571
Continue to review full report at Codecov.
|
Sorry, something went wrong.
sbinet
approved these changes
Mar 22, 2022
sbinet
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old behavior:
len({"a" : 1, "b" : 2})
New behavior returns the number of elements in the dict