Adding __delitem__ to dict - #215
Conversation
Sorry, something went wrong.
Codecov ReportBase: 74.35% // Head: 74.38% // Increases project coverage by +0.03% 🎉 Additional details and impacted files @@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 74.35% 74.38% +0.03%
==========================================
Files 76 76
Lines 12617 12625 +8
==========================================
+ Hits 9381 9391 +10
+ Misses 2563 2562 -1
+ Partials 673 672 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sorry, something went wrong.
sbinet
left a comment
There was a problem hiding this comment.
thanks for the PR.
I have 2 comments.
see below.
Sorry, something went wrong.
| str, ok := key.(String) | ||
| if ok { | ||
| _, ok := d[string(str)] | ||
| if ok { | ||
| delete(d, string(str)) | ||
| return None, nil | ||
| } | ||
| } | ||
| return nil, ExceptionNewf(KeyError, "%v", key) |
There was a problem hiding this comment.
| str, ok := key.(String) | |
| if ok { | |
| _, ok := d[string(str)] | |
| if ok { | |
| delete(d, string(str)) | |
| return None, nil | |
| } | |
| } | |
| return nil, ExceptionNewf(KeyError, "%v", key) | |
| str, ok := key.(String) | |
| if !ok { | |
| return nil, ExceptionNewf(KeyError, "%v", key) | |
| } | |
| _, ok = d[string(str)] | |
| if !ok { | |
| return nil, ExceptionNewf(KeyError, "%v", key) | |
| } | |
| delete(d, string(str)) | |
| return None, nil |
yes, it's longer, but only in the vertical dimension (however, it's less indented)
Sorry, something went wrong.
| del a["hello"] | ||
| assert not a.__contains__('hello') | ||
| assert a.__contains__('hi') | ||
|
|
There was a problem hiding this comment.
perhaps add a couple of cases that exercize the 2 ExceptionNewf branches ?
Sorry, something went wrong.
sbinet
left a comment
There was a problem hiding this comment.
LGTM
(thanks again)
Sorry, something went wrong.
Enables the 'del' command to delete items from a dict