FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updating dict intialization method by kellrott · Pull Request #217 · go-python/gpython · GitHub

/ gpython Public

Updating dict intialization method - #217

Merged
sbinet merged 2 commits into
go-python:mainfrom
bmeg:feature/dict-init
Jan 18, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Updating dict intialization method#217
sbinet merged 2 commits into
go-python:mainfrom
bmeg:feature/dict-init

Conversation

kellrott commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

Allows for dict initialization using:

  • Keyword arguments: dict(a="1", b="2", c="3")
  • Lists of tuples: dict( zip( "a,b,c".split(","), "1,2,3".split(",") ) )

codecov Bot commented Jan 17, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 74.38% // Head: 74.41% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (62fd86d) compared to base (5ef0384).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   74.38%   74.41%   +0.03%     
==========================================
  Files          76       76              
  Lines       12656    12673      +17     
==========================================
+ Hits         9414     9431      +17     
  Misses       2567     2567              
  Partials      675      675
Impacted Files Coverage Δ
py/dict.go 82.01% <100.00%> (+2.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sbinet reviewed Jan 18, 2023
View reviewed changes

sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks for the PR.
I have some comments, see below.

Comment thread py/dict.go
Comment thread py/dict.go
sbinet approved these changes Jan 18, 2023
View reviewed changes

sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

thanks again.

sbinet merged commit 337df2a into go-python:main Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbinet sbinet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL