Codecov Report

Merging #22 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage    64.5%   64.43%   -0.08%     
==========================================
  Files          55       55              
  Lines        9740     9793      +53     
==========================================
+ Hits         6283     6310      +27     
- Misses       3010     3036      +26     
  Partials      447      447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3c651...cf2d78d. Read the comment docs.

@ncw @sbinet

PTAL

@ncw @sbinet
For reviewers, The code coverage results are not related with this CL.
We can ignore the result of this.

@ncw @sbinet
I notice that the code coverage metric is not exact.
I checked that the block which said "no-cover" is already covered on the unit test.

I am on a train + mobile, so I can't easily check... But is the piece of code you say should be tested, is tested within the same package? (There's probably a way to treat a whole repo like a single code-coverage unit so that parts of pkgA that are tested from pkgB still are counted as tested. But I haven't found it.)

@sbinet
Yes, they are on the same package "parser".

I think that looks fine to me. I had a quick look through the auto generated code and it looks like it has just been tidied up. That may explain the code coverage oddities also since the line count of the generated code has increased.