| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Codecov ReportPatch coverage: 83.13% and project coverage change: +0.10 🎉 Additional details and impacted files @@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 74.42% 74.52% +0.10%
==========================================
Files 76 78 +2
Lines 12675 12804 +129
==========================================
+ Hits 9433 9542 +109
- Misses 2567 2583 +16
- Partials 675 679 +4
... and 1 file with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
There was a problem hiding this comment.
thanks for the PR.
I have mostly cosmetics comments, see below.
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
could you split the commits between implementing filter, implementing map, implementing oct and optimising hex ?
(it's good practice and brings easier to understand git-history)
if not, I'll do it, once @ncw chimed in about ObjectIsTrue.
Sorry, something went wrong.
|
Of course, I will split commit later |
Sorry, something went wrong.
|
I found that the basic types (int, string, etc.) did not run Ready() correctly, resulting some attribute was not registered correctly and was fixed by the way |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, modulo a very minor nit.
thanks again.
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM.
thanks again.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
all: support filter builtin feature and fix iterable object
Python-3.4.9/Doc/c-api/iterator.rst
Python-3.4.9/Lib/test/test_builtin.py
In CPython, Squares (5) is an iterable object, and to support this type of iterable object, I made modifications to Iterator. go
Iterator. go
Corresponding CPython code
Python-3.4.9/Objects/iterobject.c
and Iter()
Corresponding CPython code
Python-3.4.9/Objects/abstract.c
Finally, filter and map methods were fully implemented
py/tests/filter.py is a copy of Python-3.4.9/Lib/test/test_builtin.py:BuiltinTest.test_filter()
and
py/tests/map.py is a copy of Python-3.4.9/Lib/test/test_builtin.py:BuiltinTest.test_map()
builtin: Implement oct and optimise hex
Through benchmark testing, the speed of hex has indeed been improved
My English is not very good, so forgive me for not providing sufficient explanations. Welcome to ask questions here