FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

py: Fix TracebackDump not to dump duplicated exception type by corona10 · Pull Request #36 · go-python/gpython · GitHub

py: Fix TracebackDump not to dump duplicated exception type - #36

Merged
ncw merged 1 commit into
go-python:masterfrom
corona10:gh-23
Nov 24, 2018
Merged

py: Fix TracebackDump not to dump duplicated exception type#36
ncw merged 1 commit into
go-python:masterfrom
corona10:gh-23

Conversation

Copy link
Copy Markdown
Collaborator

Fixes: #23

codecov-io commented Nov 23, 2018
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #36 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   65.23%   65.25%   +0.01%     
==========================================
  Files          56       56              
  Lines       10151    10148       -3     
==========================================
  Hits         6622     6622              
+ Misses       3067     3064       -3     
  Partials      462      462
Impacted Files Coverage Δ
py/exception.go 34.54% <0%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b715616...703534e. Read the comment docs.

Copy link
Copy Markdown
Collaborator Author

@ncw
PTAL, proper unit test can't add this time.
Maybe we can add capturing fmt.Fprintf but not the easy job to this.

corona10 requested a review from ncw November 23, 2018 21:56
corona10 changed the title py: Fix TracebackDump to not dump duplicated exception type py: Fix TracebackDump not to dump duplicated exception type Nov 24, 2018

ncw commented Nov 24, 2018

Copy link
Copy Markdown
Collaborator

PTAL, proper unit test can't add this time.
Maybe we can add capturing fmt.Fprintf but not the easy job to this.

Well I think it is a definite improvement, so I'll merge it - thank you :-)

ncw merged commit 2981ee9 into go-python:master Nov 24, 2018
corona10 deleted the gh-23 branch November 24, 2018 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL