FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

py: Support __len__ of rangetype. by corona10 · Pull Request #40 · go-python/gpython · GitHub

py: Support __len__ of rangetype. - #40

Merged
ncw merged 1 commit into
go-python:masterfrom
corona10:gh-39
Dec 26, 2018
Merged

py: Support __len__ of rangetype.#40
ncw merged 1 commit into
go-python:masterfrom
corona10:gh-39

Conversation

Copy link
Copy Markdown
Collaborator

Fixes: #39

corona10 requested a review from ncw December 24, 2018 15:47

codecov-io commented Dec 24, 2018
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #40 into master will increase coverage by 0.46%.
The diff coverage is 84.61%.

@@            Coverage Diff            @@
##           master     #40      +/-   ##
=========================================
+ Coverage   65.24%   65.7%   +0.46%     
=========================================
  Files          56      56              
  Lines       10150   10170      +20     
=========================================
+ Hits         6622    6682      +60     
+ Misses       3066    3019      -47     
- Partials      462     469       +7
Impacted Files Coverage Δ
py/range.go 75% <84.61%> (+75%) ⬆️
py/arithmetic.go 61.69% <0%> (+1.11%) ⬆️
py/list.go 10.05% <0%> (+1.18%) ⬆️
py/function.go 25.95% <0%> (+1.52%) ⬆️
py/sequence.go 23.65% <0%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ea0a4...dafaabf. Read the comment docs.

Copy link
Copy Markdown
Collaborator Author

@ncw PTAL

ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very nice - thank you :-)

ncw merged commit 82240ed into go-python:master Dec 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL