FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

builtin: Implement enumerate feature by corona10 · Pull Request #43 · go-python/gpython · GitHub

/ gpython Public

builtin: Implement enumerate feature - #43

Merged
ncw merged 1 commit into
go-python:masterfrom
corona10:enumerate
Dec 26, 2018
ConversationCommits (1)ChecksFiles changed
Merged

builtin: Implement enumerate feature#43
ncw merged 1 commit into
go-python:masterfrom
corona10:enumerate

Conversation

corona10 commented Dec 25, 2018

Copy link
Copy Markdown
Collaborator

Now, gpython supports enumerate feature

corona10 requested a review from ncw December 25, 2018 11:24

codecov-io commented Dec 25, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #43 into master will increase coverage by 0.3%.
The diff coverage is 72.22%.

@@            Coverage Diff            @@
##           master      #43     +/-   ##
=========================================
+ Coverage   65.24%   65.55%   +0.3%     
=========================================
  Files          56       57      +1     
  Lines       10150    10186     +36     
=========================================
+ Hits         6622     6677     +55     
+ Misses       3066     3040     -26     
- Partials      462      469      +7
Impacted Files Coverage Δ
builtin/builtin.go 78.72% <100%> (+0.05%) ⬆️
py/enumerate.go 71.42% <71.42%> (ø)
py/arithmetic.go 61.69% <0%> (+1.11%) ⬆️
py/function.go 25.95% <0%> (+1.52%) ⬆️
py/tuple.go 24.52% <0%> (+2.83%) ⬆️
py/list.go 11.83% <0%> (+2.95%) ⬆️
py/sequence.go 23.65% <0%> (+3.22%) ⬆️
py/iterator.go 73.33% <0%> (+73.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ea0a4...afd9be0. Read the comment docs.

corona10 force-pushed the enumerate branch 2 times, most recently from cfd27cb to 0f75714 Compare December 25, 2018 11:37

corona10 commented Dec 25, 2018

Copy link
Copy Markdown
Collaborator Author

@ncw PTAL

builtin: Implement enumerate feature
afd9be0 
Now, gpython supports enumerate feature
ncw approved these changes Dec 26, 2018
View reviewed changes

ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That looks great :-)

I didn't know enumerate took another parameter!

ncw merged commit 5e97b9b into go-python:master Dec 26, 2018

corona10 commented Dec 27, 2018

Copy link
Copy Markdown
Collaborator Author

@ncw
It's the funniest part of this work!

corona10 deleted the enumerate branch December 27, 2018 00:52

ncw commented Dec 29, 2018

Copy link
Copy Markdown
Collaborator

@ncw
It's the funniest part of this work!

Indeed, learning lots of arcane things about python!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncw ncw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL