FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

builtin: Implement builtin_iter by corona10 · Pull Request #54 · go-python/gpython · GitHub

/ gpython Public

builtin: Implement builtin_iter - #54

Merged
corona10 merged 1 commit into
go-python:masterfrom
corona10:builtin_iter
Feb 14, 2019
ConversationCommits (1)ChecksFiles changed
Merged

builtin: Implement builtin_iter#54
corona10 merged 1 commit into
go-python:masterfrom
corona10:builtin_iter

Conversation

corona10 commented Feb 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Implement CallIterator
  • Implement builtin iter()

Closes: #53

corona10 changed the title builtin: Implement builtin_iter [WIP] builtin: Implement builtin_iter Feb 13, 2019

corona10 commented Feb 13, 2019

Copy link
Copy Markdown
Collaborator Author

This is WIP PR do not merge!

codecov-io commented Feb 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #54 into master will increase coverage by 0.32%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   66.09%   66.42%   +0.32%     
==========================================
  Files          58       59       +1     
  Lines       10332    10368      +36     
==========================================
+ Hits         6829     6887      +58     
+ Misses       3017     2989      -28     
- Partials      486      492       +6
Impacted Files Coverage Δ
builtin/builtin.go 79.58% <100%> (+0.81%) ⬆️
py/call_iterator.go 75% <75%> (ø)
py/list.go 21.3% <0%> (+8.28%) ⬆️
py/sequence.go 34.4% <0%> (+10.75%) ⬆️
py/iterator.go 86.66% <0%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fb6f3...6b0f6b1. Read the comment docs.

corona10 added the WIP label Feb 13, 2019
corona10 force-pushed the builtin_iter branch 2 times, most recently from 8aceacc to 14c5813 Compare February 13, 2019 17:50
corona10 changed the title [WIP] builtin: Implement builtin_iter builtin: Implement builtin_iter Feb 13, 2019
corona10 removed the WIP label Feb 13, 2019
corona10 requested a review from ncw February 13, 2019 17:58

corona10 commented Feb 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@ncw
Hi, Nick please take a look if you have time!

ncw reviewed Feb 13, 2019
View reviewed changes

ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That looks great! Just one minor point inline.

Comment thread py/call_iterator.go Outdated

corona10 commented Feb 14, 2019

Copy link
Copy Markdown
Collaborator Author

@ncw
Wow, thanks for the fast review!!
I 've updated the PR as you commented!

ncw approved these changes Feb 14, 2019
View reviewed changes

ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That looks great now - merge away :-)

corona10 merged commit 344a390 into go-python:master Feb 14, 2019
corona10 deleted the builtin_iter branch February 14, 2019 10:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncw ncw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL