FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

builtin: Implement delattr by corona10 · Pull Request #55 · go-python/gpython · GitHub

/ gpython Public

builtin: Implement delattr - #55

Merged
corona10 merged 1 commit into
go-python:masterfrom
corona10:builtin_delattr
Feb 15, 2019
ConversationCommits (1)ChecksFiles changed
Merged

builtin: Implement delattr#55
corona10 merged 1 commit into
go-python:masterfrom
corona10:builtin_delattr

Conversation

corona10 commented Feb 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I've implemented delattr for builtin function.

corona10 requested a review from ncw February 14, 2019 17:53

codecov-io commented Feb 14, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #55 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   66.42%   66.44%   +0.01%     
==========================================
  Files          59       59              
  Lines       10368    10379      +11     
==========================================
+ Hits         6887     6896       +9     
- Misses       2989     2990       +1     
- Partials      492      493       +1
Impacted Files Coverage Δ
builtin/builtin.go 79.62% <81.81%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344a390...c625d39. Read the comment docs.

corona10 commented Feb 14, 2019

Copy link
Copy Markdown
Collaborator Author

@ncw
Please take a look.
This is a pretty easy PR then before. :)

I'd like to see that gpython could run stdlib in this year.
I expect that we must update some object structure.
And this will be a rough road.

ncw approved these changes Feb 14, 2019
View reviewed changes

ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lgtm :-)

corona10 merged commit 0c9eac8 into go-python:master Feb 15, 2019
corona10 deleted the builtin_delattr branch February 15, 2019 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncw ncw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL