FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

py: Fix __mul__ of list and tuple on negative case by corona10 · Pull Request #67 · go-python/gpython · GitHub

py: Fix __mul__ of list and tuple on negative case - #67

Merged
corona10 merged 1 commit into
go-python:masterfrom
corona10:fix_mul
Jul 28, 2019
Merged

py: Fix __mul__ of list and tuple on negative case#67
corona10 merged 1 commit into
go-python:masterfrom
corona10:fix_mul

Conversation

Copy link
Copy Markdown
Collaborator

py: Fix mul of list and tuple on negative case

Copy link
Copy Markdown

Codecov Report

Merging #67 into master will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   68.45%   68.61%   +0.16%     
==========================================
  Files          59       59              
  Lines       10495    10499       +4     
==========================================
+ Hits         7184     7204      +20     
+ Misses       2804     2788      -16     
  Partials      507      507
Impacted Files Coverage Δ
py/tuple.go 39.81% <100%> (+8.68%) ⬆️
py/list.go 35.13% <100%> (+5.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b8c68...b4d99f5. Read the comment docs.

Copy link
Copy Markdown
Collaborator Author

@ncw PTAL

corona10 requested a review from ncw July 27, 2019 13:46

ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great please merge 😀

corona10 merged commit bd0985b into go-python:master Jul 28, 2019
corona10 deleted the fix_mul branch July 28, 2019 01:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL