FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implement and of set by DoDaek · Pull Request #82 · go-python/gpython · GitHub

/ gpython Public

Implement and of set - #82

Merged
corona10 merged 3 commits into
go-python:masterfrom
DoDaek:issue-76
Sep 16, 2019
ConversationCommits (3)ChecksFiles changed
Merged

Implement and of set#82
corona10 merged 3 commits into
go-python:masterfrom
DoDaek:issue-76

Conversation

DoDaek commented Sep 15, 2019

Copy link
Copy Markdown
Contributor

ISSUE: #76

corona10 requested changes Sep 15, 2019
View reviewed changes
Comment thread py/tests/set.py Outdated
@@ -0,0 +1,16 @@
# Copyright 2018 The go-python Authors. All rights reserved.

corona10 Sep 15, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copyright 2018 -> Copyright 2019

Comment thread py/set.go Outdated
ret := NewSet()
b, ok := other.(*Set)
if !ok {
return nil, TypeError

corona10 Sep 15, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality 
return nil, ExceptionNewf(TypeError, "unsupported operand type(s) for &: '%s' and '%s'", s.Type().Name, other.Type().Name)

DoDaek Sep 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I changed the return value of the function

codecov-io commented Sep 15, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #82 into master will increase coverage by 0.17%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   68.65%   68.83%   +0.17%     
==========================================
  Files          59       59              
  Lines       10525    10534       +9     
==========================================
+ Hits         7226     7251      +25     
+ Misses       2790     2774      -16     
  Partials      509      509
Impacted Files Coverage Δ
py/set.go 31.08% <77.77%> (+31.08%) ⬆️
py/sequence.go 54.83% <0%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb115a9...ca6e411. Read the comment docs.

corona10 approved these changes Sep 16, 2019
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM Thanks for the contribution. @DoDaek

corona10 merged commit 4f7bb19 into go-python:master Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL