set: Implement __or__ of set - #84
Merged
corona10 merged 2 commits intoSep 17, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
corona10
requested changes
Sep 17, 2019
corona10
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Implementation is wrong
Expected
>>> a = {1,2,3}
>>> b = {4,5,6}
>>> a | b
{1, 2, 3, 4, 5, 6}
>>> 4 in a
False
>>>Got
>>> a = {1,2,3}
>>> b = {4,5,6}
>>> a | b
<set instance at 0xc0003f8000>
>>> a
<set instance at 0xc0003f8000>
>>> 4 in a
True
>>>
Sorry, something went wrong.
corona10
reviewed
Sep 17, 2019
Comment thread
py/set.go
Outdated
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 68.83% 68.84% +0.01%
==========================================
Files 59 59
Lines 10534 10545 +11
==========================================
+ Hits 7251 7260 +9
- Misses 2774 2775 +1
- Partials 509 510 +1
Continue to review full report at Codecov.
|
Sorry, something went wrong.
corona10
approved these changes
Sep 17, 2019
corona10
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement or of set
ISSUE: #76