FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add __new__ function and property of slice by HyeockJinKim · Pull Request #99 · go-python/gpython · GitHub

Add __new__ function and property of slice - #99

Merged
corona10 merged 2 commits into
go-python:masterfrom
HyeockJinKim:issue98
Sep 29, 2019
Merged

Add __new__ function and property of slice#99
corona10 merged 2 commits into
go-python:masterfrom
HyeockJinKim:issue98

Conversation

Copy link
Copy Markdown
Contributor

Issue #98

codecov-io commented Sep 29, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #99 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   69.09%   69.23%   +0.14%     
==========================================
  Files          60       60              
  Lines       10675    10692      +17     
==========================================
+ Hits         7376     7403      +27     
+ Misses       2781     2770      -11     
- Partials      518      519       +1
Impacted Files Coverage Δ
builtin/builtin.go 79.71% <100%> (+0.03%) ⬆️
py/slice.go 82% <100%> (+15.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c361a8...a604dc8. Read the comment docs.

Copy link
Copy Markdown
Contributor Author

@corona10
Can I get a review?

corona10 requested review from corona10 and ncw September 29, 2019 07:48
Comment thread builtin/testfile Outdated

corona10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

corona10 merged commit 4b996c8 into go-python:master Sep 29, 2019
HyeockJinKim deleted the issue98 branch September 29, 2019 12:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL