FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: adjust billing collection logic by pbennett1-godaddy · Pull Request #1438 · godaddy/javascript · GitHub

/ javascript Public

fix: adjust billing collection logic - #1438

Open
pbennett1-godaddy wants to merge 22 commits into
mainfrom
fix-billing-collection-logic
ConversationCommits (22)ChecksFiles changed
Open

fix: adjust billing collection logic#1438
pbennett1-godaddy wants to merge 22 commits into
mainfrom
fix-billing-collection-logic

Conversation

pbennett1-godaddy commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Updates billing collection so checkout consistently shows and validates only the information required for each delivery and payment flow.

  • Offline pickup collects names and optional phone because taxes use the pickup location.
  • Offline purchase and digital orders collect a billing address only when needed for taxes.
  • Free orders follow the same billing rules as offline orders.
  • Shipping orders can reuse the shipping address only when shipping-address collection is enabled.
  • enableBillingAddressCollection: false is respected across all flows.
  • Billing addresses are cleared when switching to a names-only flow.
  • Discounts recalculate taxes correctly for purchase and digital orders.

Changeset

  • Changeset added (docs)

Test Plan

Ran the full React package test suite:

pnpm --filter @godaddy/react test

Also ran:

  pnpm --filter @godaddy/react build                                                                                                                                                                      
  pnpm --filter @godaddy/react typecheck

Result:

  Test Files  52 passed                                                                                                                                                                                   
  Tests       551 passed                                                                                                                                                                                  
  Build       passed                                                                                                                                                                                      
  Typecheck   passed

pbennett1-godaddy requested a review from a team as a code owner August 19, 2026 15:22

changeset-bot Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 29c4f33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@godaddy/react Patch
nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

add changeset
2caa59f
feat(react): add billing policy resolver
4db2dc6 
Task: task-2
test(react): lock billing policy contracts
a5c1135 
Task: task-1
feat(react): migrate billing renderers to policy
188cf87 
Task: task-4
feat(react): refactor checkout trigger field filtering
933221c 
Task: task-5
feat(react): add billing policy transition controller
33207a6 
Task: task-3
feat(react): add policy-aware checkout validation adapter
111fe18 
Task: task-6
feat(react): finalize billing policy validation
8f77713 
Task: task-7
biome fix
48012b4
do not prevent tax call on zero order after discount
89ab144
update billing policy for shipping scenarios
222590a
add tax fix for discounts on purchase and digital orders
29664cb
update billing policy for shipping flags
bfb13f8
adjust changeset
6a7e6c7
use consts for billing mode and locations
3af3471
add additional billing tests and do not treat null total as free
b10a141
add billing address to stripe payments
c7c5885
adjust sku and order hydration and refetches
d845174
always use flushed updated order on checkout
4057110
checkout payment flush test for e2e with latest order
f46f8f0
hydrate contact email from shipping or billing data
29c4f33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL