FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update form block save for WordPress 6.3 by eherman-godaddy · Pull Request #2543 · godaddy-wordpress/coblocks · GitHub

/ coblocks Public

Update form block save for WordPress 6.3 - #2543

Merged
EvanHerman merged 1 commit into
masterfrom
form-block-6.3
Jul 28, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Update form block save for WordPress 6.3#2543
EvanHerman merged 1 commit into
masterfrom
form-block-6.3

Conversation

eherman-godaddy commented Jul 28, 2023 •
edited by EvanHerman
Loading

Copy link
Copy Markdown
Contributor

Description

  • Update the form block save for WordPress 6.3 compatibility.
  • Updated the caniuse database version.

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Manually tested a migration from 6.2 with an existing form to 6.3 with the same form.
  • Manually tested setting up a new form in both 6.2 and 6.3.

Acceptance criteria

  • Form should load in the editor without any validation errors, and show up on the front of site.
  • No visible changes between WordPress 6.2 and 6.3.

Checklist:

  • My code is tested
  • I've added proper labels to this pull request

eherman-godaddy added the [Type] Enhancement Something new that adds functionality label Jul 28, 2023
eherman-godaddy requested a review from snovosel July 28, 2023 15:07
eherman-godaddy self-assigned this Jul 28, 2023
eherman-godaddy marked this pull request as ready for review July 28, 2023 15:20
snovosel-godaddy self-requested a review July 28, 2023 15:22
snovosel-godaddy approved these changes Jul 28, 2023
View reviewed changes

snovosel-godaddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

EvanHerman merged commit e744d3b into master Jul 28, 2023
EvanHerman deleted the form-block-6.3 branch July 28, 2023 15:23

EvanHerman commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

I'm going to look into why the unit tests aren't running in a separate PR.

AnthonyLedesma commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Is a little concerning to see the E2E failures here, especially the Form block. Seems like it may be a temporary issue luckily.

AnthonyLedesma added this to the 3.1.0 milestone Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

snovosel Awaiting requested review from snovosel
1 more reviewer
snovosel-godaddy snovosel-godaddy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

EvanHerman

Labels

[Type] Enhancement Something new that adds functionality

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL