Fix Shape Divider default applied classes - #2553
Merged
AnthonyLedesma merged 5 commits intoAug 10, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jrtashjian
approved these changes
Aug 10, 2023
Comment thread
src/blocks/shape-divider/index.php
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Trying to work with GitHub Actions issues all day with this PR. Unfortunately, GitHub is experiencing some issues with actions today, and our release pipeline relies on GitHub Actions. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Tests are passing locally. Merging without CICD passing. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improper PHP logic resulted in improperly applying class names to shape divider blocks on the published pages.
Fixed logic and added a new E2E test that would detect this condition in the future.
Screenshots
Before
After
Types of changes
PHP Logic.
Testing.
How has this been tested?
Manually, E2E.
Acceptance criteria
Should properly apply default classes when expected.
Checklist: