FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix disappearing buttons inside of Services blocks by jgutierrezmoren-godaddy · Pull Request #2613 · godaddy-wordpress/coblocks · GitHub

/ coblocks Public

Fix disappearing buttons inside of Services blocks - #2613

Merged
AnthonyLedesma merged 2 commits into
masterfrom
WPEX-3677__coblocks-disappearing-content
Jun 13, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Fix disappearing buttons inside of Services blocks#2613
AnthonyLedesma merged 2 commits into
masterfrom
WPEX-3677__coblocks-disappearing-content

Conversation

jgutierrezmoren-godaddy commented Jun 10, 2024

Copy link
Copy Markdown
Contributor

Description

Removed 'Display button' toggle from the services and service blocks.
Link to issue WPEX-3677

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manual regression testing

Acceptance criteria

'Display button' toggle should be completely removed after deciding to allow users to place buttons within the inner blocks if they choose.

Checklist:

  • Code is tested so that the removed feature does not introduce any issues

jgutierrezmoren-godaddy added First-time Contributor Pull request opened by a first-time contributor javascript Pull requests that update Javascript code labels Jun 10, 2024
snovosel-godaddy requested review from snovosel-godaddy and removed request for snovosel June 10, 2024 15:00
AnthonyLedesma suggested changes Jun 10, 2024
View reviewed changes

AnthonyLedesma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This test must be changed

coblocks/src/blocks/services/test/services.cypress.js

Lines 91 to 107 in 0206e8e

/**
* Test that we can add a services block to the content, enable
* action buttons and are able to successfully save the block without errors.
*/
it( 'Test services block saves with action buttons enabled.', function() {
helpers.addBlockToPost( 'coblocks/services', true );
cy.get( 'div.wp-block-button' ).should( 'not.exist' );
helpers.toggleSettingCheckbox( /display buttons/i );
cy.get( '.wp-block-buttons' ).should( 'have.length', 2 );
helpers.savePage();
helpers.checkForBlockErrors( 'coblocks/services' );
} );

AnthonyLedesma added this to the Next Release milestone Jun 13, 2024
AnthonyLedesma approved these changes Jun 13, 2024
View reviewed changes

AnthonyLedesma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great work. I was not able to break the block, or trigger a deprecation error. Should be good to release.

AnthonyLedesma changed the title WPEX-3677 remove display button toggle from services block Fix disappearing buttons inside of Services blocks Jun 13, 2024
AnthonyLedesma merged commit 89c02ac into master Jun 13, 2024
AnthonyLedesma deleted the WPEX-3677__coblocks-disappearing-content branch June 13, 2024 20:59
This was referenced Jul 25, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
AnthonyLedesma AnthonyLedesma approved these changes
snovosel-godaddy snovosel-godaddy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

First-time Contributor Pull request opened by a first-time contributor javascript Pull requests that update Javascript code

Projects

None yet

Milestone

3.1.11

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL